Bug 595455 - rgmanager does not remove nfs service temp directories when using nfslock=1
Summary: rgmanager does not remove nfs service temp directories when using nfslock=1
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: rgmanager
Version: 5.5
Hardware: All
OS: Linux
medium
medium
Target Milestone: rc
: ---
Assignee: Lon Hohberger
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-05-24 16:38 UTC by Carlos Maiolino
Modified: 2018-11-14 19:30 UTC (History)
5 users (show)

Fixed In Version: rgmanager-2.0.52-6.13.el5
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2011-01-13 23:26:23 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
create temp dirs only after the script pass the first if conditions (591 bytes, patch)
2010-05-24 16:42 UTC, Carlos Maiolino
lhh: review+
Details | Diff


Links
System ID Private Priority Status Summary Last Updated
Red Hat Knowledge Base (Solution) 32272 0 None None None 2012-07-31 15:42:22 UTC
Red Hat Product Errata RHBA-2011:0134 0 normal SHIPPED_LIVE rgmanager bug fix and enhancement update 2011-01-12 19:20:47 UTC

Description Carlos Maiolino 2010-05-24 16:38:02 UTC
Description of problem:

when using nfslock=1, rgmanager does not remove temp directories (statd-*) created on /tmp when they are no longer needed.

Version-Release number of selected component (if applicable):

rgmanager-2.0.52-6.el5

How reproducible:
Always

Steps to Reproduce:
1. Setup a simple NFS cluster (2-node is enough)
2. Setup a simple nfs service setting nfslock=1
3. Start nfs service in any node and statd-* directories are created on /tmp of that node.
4. Stop nfs service on the node and the statd-* directories are not removed.
  
Actual results:

Temp directories are not removed from /tmp directory

Expected results:

Directories are removed when not necessary.

Additional info:

Temp directories are created by /usr/share/cluster/svclib_nfslock script, which should remove these files at the end of the script.
But, if the script return on one of the first 'if' instructions, the temp directories are not removed.

Comment 1 Carlos Maiolino 2010-05-24 16:42:23 UTC
Created attachment 416172 [details]
create temp dirs only after the script pass the first if conditions

If the script creates the temp directories only after pass by the if conditions, the temp directories are properly removed.

Comment 2 Lon Hohberger 2010-05-26 19:49:05 UTC
The patch is correct.

Comment 5 errata-xmlrpc 2011-01-13 23:26:23 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0134.html


Note You need to log in before you can comment on or make changes to this bug.