Bug 596659

Summary: Review Request: ofl-sorts-mill-goudy-fonts - Goudy Oldstyle and Italic fonts
Product: [Fedora] Fedora Reporter: Parag Nemade <pnemade>
Component: Package ReviewAssignee: Daiki Ueno <dueno>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: dueno, fedora-package-review, i18n-bugs, notting
Target Milestone: ---Flags: dueno: fedora-review+
kevin: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-07-01 06:36:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Parag Nemade 2010-05-27 09:15:46 UTC
Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/ofl-sorts-mill-goudy-fonts.spec
SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/ofl-sorts-mill-goudy-fonts-003.000-1.fc13.src.rpm
Description: 
Goudy Oldstyle and Italic (based on ATF foundry type)

Comment 2 Daiki Ueno 2010-05-28 06:53:59 UTC
Mostly ok.  How about including FONTLOG to doc?

Cosmetic things:

- the "Version" is 003.000 (which came from the font, right?), but the upstream uses simpler naming for the archive: ofl-goudy-3.0.zip.  I think we could use 3.0.

- rpmlint spews a couple of warnings (harmless, I think):

 ofl-sorts-mill-goudy-fonts.src: W: invalid-url Source0: http://sortsmill.googlecode.com/files/ofl-goudy-3.0.zip HTTP Error 404: Not Found
 ofl-sorts-mill-goudy-fonts.src: W: uncompressed-zip ofl-goudy-3.0.zip

I have no idea how to workaround them :)

Comment 4 Daiki Ueno 2010-05-31 02:32:20 UTC
Looks ok.

Comment 5 Parag Nemade 2010-05-31 07:48:40 UTC
Thank you for the review Daiki.

New Package CVS Request
=======================
Package Name: ofl-sorts-mill-goudy-fonts
Short Description: Goudy Oldstyle and Italic fonts
Owners: pnemade
Branches: F-13 
InitialCC: fonts-sig i18n-team

Comment 6 Kevin Fenzi 2010-05-31 19:28:13 UTC
CVS done (by process-cvs-requests.py).

Comment 7 Fedora Update System 2010-06-01 05:34:41 UTC
ofl-sorts-mill-goudy-fonts-3.0-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/ofl-sorts-mill-goudy-fonts-3.0-1.fc13

Comment 8 Fedora Update System 2010-06-01 18:26:14 UTC
ofl-sorts-mill-goudy-fonts-3.0-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update ofl-sorts-mill-goudy-fonts'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ofl-sorts-mill-goudy-fonts-3.0-1.fc13