Bug 596659 - Review Request: ofl-sorts-mill-goudy-fonts - Goudy Oldstyle and Italic fonts
Summary: Review Request: ofl-sorts-mill-goudy-fonts - Goudy Oldstyle and Italic fonts
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Daiki Ueno
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-05-27 09:15 UTC by Parag Nemade
Modified: 2010-07-01 06:36 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-07-01 06:36:53 UTC
Type: ---
Embargoed:
dueno: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Parag Nemade 2010-05-27 09:15:46 UTC
Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/ofl-sorts-mill-goudy-fonts.spec
SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/ofl-sorts-mill-goudy-fonts-003.000-1.fc13.src.rpm
Description: 
Goudy Oldstyle and Italic (based on ATF foundry type)

Comment 2 Daiki Ueno 2010-05-28 06:53:59 UTC
Mostly ok.  How about including FONTLOG to doc?

Cosmetic things:

- the "Version" is 003.000 (which came from the font, right?), but the upstream uses simpler naming for the archive: ofl-goudy-3.0.zip.  I think we could use 3.0.

- rpmlint spews a couple of warnings (harmless, I think):

 ofl-sorts-mill-goudy-fonts.src: W: invalid-url Source0: http://sortsmill.googlecode.com/files/ofl-goudy-3.0.zip HTTP Error 404: Not Found
 ofl-sorts-mill-goudy-fonts.src: W: uncompressed-zip ofl-goudy-3.0.zip

I have no idea how to workaround them :)

Comment 4 Daiki Ueno 2010-05-31 02:32:20 UTC
Looks ok.

Comment 5 Parag Nemade 2010-05-31 07:48:40 UTC
Thank you for the review Daiki.

New Package CVS Request
=======================
Package Name: ofl-sorts-mill-goudy-fonts
Short Description: Goudy Oldstyle and Italic fonts
Owners: pnemade
Branches: F-13 
InitialCC: fonts-sig i18n-team

Comment 6 Kevin Fenzi 2010-05-31 19:28:13 UTC
CVS done (by process-cvs-requests.py).

Comment 7 Fedora Update System 2010-06-01 05:34:41 UTC
ofl-sorts-mill-goudy-fonts-3.0-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/ofl-sorts-mill-goudy-fonts-3.0-1.fc13

Comment 8 Fedora Update System 2010-06-01 18:26:14 UTC
ofl-sorts-mill-goudy-fonts-3.0-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update ofl-sorts-mill-goudy-fonts'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/ofl-sorts-mill-goudy-fonts-3.0-1.fc13


Note You need to log in before you can comment on or make changes to this bug.