|Summary:||Review Request: libnmserver - library which exposes various information from NetworkManager|
|Product:||[Fedora] Fedora||Reporter:||Adam Tkac <atkac>|
|Component:||Package Review||Assignee:||Ian Weller <ian>|
|Status:||CLOSED NEXTRELEASE||QA Contact:||Fedora Extras Quality Assurance <extras-qa>|
|Version:||rawhide||CC:||fedora-package-review, ian, jgorig, notting, ovasik|
|Fixed In Version:||libnmserver-0.0.91-1.fc14||Doc Type:||Bug Fix|
|Doc Text:||Story Points:||---|
|Last Closed:||2010-07-19 13:55:22 UTC||Type:||---|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
Description Adam Tkac 2010-06-04 10:25:26 UTC
Spec URL: http://atkac.fedorapeople.org/libnmserver/libnmserver.spec SRPM URL: http://atkac.fedorapeople.org/libnmserver/libnmserver-0.0.90-1.fc14.src.rpm Description: This library exposes various information from NetworkManager through C API. It is small and has minimal set of external dependencies.
Comment 1 Ian Weller 2010-06-15 03:44:03 UTC
[ OK ] specfiles match: 4f87fa3cd37d119339d4f899120ed76a libnmserver.spec 4f87fa3cd37d119339d4f899120ed76a libnmserver.spec.1 [ OK ] source files match upstream: 3bf81b09bf6dd26f4187b6d7af2193b0 libnmserver-0.0.90.tar.gz 3bf81b09bf6dd26f4187b6d7af2193b0 libnmserver-0.0.90.tar.gz.1 [ OK ] package meets naming and versioning guidelines. [ OK ] spec is properly named, cleanly written, and uses macros consistently. [ OK ] dist tag is present. [ OK ] build root is correct. [ OK ] license field matches the actual license. [ OK ] license is open source-compatible. [FAILED] license text included in package. This isn't a blocker, but please ask upstream to include a COPYING file, then include it in %doc in a future specfile. [ OK ] latest version is being packaged. [ OK ] BuildRequires are proper. [ OK ] compiler flags are appropriate. [ OK ] %clean is present. [ OK ] package builds in mock. [ OK ] package installs properly. [ OK ] debuginfo package looks complete. [FAILED] rpmlint is silent. libnmserver.x86_64: W: no-documentation libnmserver-devel.x86_64: W: no-documentation (once again not a blocker, see "license text included in package") [ OK ] final provides and requires are sane [ N/A ] %check is present and all tests pass: [ OK ] shared libraries aren't added to linker search paths without ldconfig. [ OK ] owns the directories it creates. [ OK ] doesn't own any directories it shouldn't. [ OK ] no duplicates in %files. [ OK ] file permissions are appropriate. [ OK ] scriptlets match those on ScriptletSnippets page. [ OK ] code, not content. [ OK ] documentation is small, so no -docs subpackage is necessary. [ N/A ] %docs are not necessary for the proper functioning of the package. [ OK ] headers in devel subpackage. [ OK ] pkgconfig files in devel subpackage. [ OK ] no libtool .la droppings. [ N/A ] desktop files valid and installed properly. ---------------------------------------- This package (libnmserver) is APPROVED ---------------------------------------- Please be sure to contact upstream to add a COPYING file, then add that to %doc.
Comment 2 Adam Tkac 2010-06-28 14:13:44 UTC
Thanks for the review, upstream just released 0.0.91 version with the LICENSE.txt included, I will add it to %doc.
Comment 3 Adam Tkac 2010-06-28 14:17:42 UTC
New Package CVS Request ======================= Package Name: libnmserver Short Description: library which exposes various information from NetworkManager Owners: atkac Branches: devel InitialCC: jgorig
Comment 4 Jason Tibbitts 2010-06-28 16:43:05 UTC
CVS done (by process-cvs-requests.py).
Comment 5 Adam Tkac 2010-07-19 13:55:22 UTC
Fixed in libnmserver-0.0.91-1.fc14, thank you for the review.