Red Hat Bugzilla – Bug 600270
Review Request: libnmserver - library which exposes various information from NetworkManager
Last modified: 2013-04-30 19:46:28 EDT
Spec URL: http://atkac.fedorapeople.org/libnmserver/libnmserver.spec
SRPM URL: http://atkac.fedorapeople.org/libnmserver/libnmserver-0.0.90-1.fc14.src.rpm
Description: This library exposes various information from NetworkManager through C API. It is small and has minimal set of external dependencies.
[ OK ] specfiles match:
[ OK ] source files match upstream:
[ OK ] package meets naming and versioning guidelines.
[ OK ] spec is properly named, cleanly written, and uses macros consistently.
[ OK ] dist tag is present.
[ OK ] build root is correct.
[ OK ] license field matches the actual license.
[ OK ] license is open source-compatible.
[FAILED] license text included in package.
This isn't a blocker, but please ask upstream to include a COPYING file, then
include it in %doc in a future specfile.
[ OK ] latest version is being packaged.
[ OK ] BuildRequires are proper.
[ OK ] compiler flags are appropriate.
[ OK ] %clean is present.
[ OK ] package builds in mock.
[ OK ] package installs properly.
[ OK ] debuginfo package looks complete.
[FAILED] rpmlint is silent.
libnmserver.x86_64: W: no-documentation
libnmserver-devel.x86_64: W: no-documentation
(once again not a blocker, see "license text included in package")
[ OK ] final provides and requires are sane
[ N/A ] %check is present and all tests pass:
[ OK ] shared libraries aren't added to linker search paths without ldconfig.
[ OK ] owns the directories it creates.
[ OK ] doesn't own any directories it shouldn't.
[ OK ] no duplicates in %files.
[ OK ] file permissions are appropriate.
[ OK ] scriptlets match those on ScriptletSnippets page.
[ OK ] code, not content.
[ OK ] documentation is small, so no -docs subpackage is necessary.
[ N/A ] %docs are not necessary for the proper functioning of the package.
[ OK ] headers in devel subpackage.
[ OK ] pkgconfig files in devel subpackage.
[ OK ] no libtool .la droppings.
[ N/A ] desktop files valid and installed properly.
This package (libnmserver) is APPROVED
Please be sure to contact upstream to add a COPYING file, then add that to %doc.
Thanks for the review, upstream just released 0.0.91 version with the LICENSE.txt included, I will add it to %doc.
New Package CVS Request
Package Name: libnmserver
Short Description: library which exposes various information from NetworkManager
CVS done (by process-cvs-requests.py).
Fixed in libnmserver-0.0.91-1.fc14, thank you for the review.