Bug 600637
| Summary: | Review Request: gnome-js-common - Common modules for GNOME JavaScript interpreters | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michel Lind <michel> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | gnome-js-common-0.1.2-3.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-06-19 15:19:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 600638 | ||
|
Description
Michel Lind
2010-06-05 10:48:23 UTC
Well, as some Japanese people said that it was said that
his favorite "Same Gnome" disappeared, I will review this...
Simple package. Some notes
* noarch handling
----------------------------------------------------
%patch1 -p1 -b .license
%build
# not using standard configure macro. Nothing is compiled,
# only prefix needed
./configure --prefix %{_prefix}
----------------------------------------------------
- Why don't you just use the following?
----------------------------------------------------
%configure --libdir=%{_datadir}
----------------------------------------------------
* Timestamps
- Trying to keep timestamps on installed files is appreciated
especially because this is based on recent autotools method
and this is noarch. Please consider to use below:
----------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
----------------------------------------------------
* Cleanups
- rpmlint may complain, however:
* On Fedora BuildRoot tag is no longer used:
https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
* On Fedora 13+, %clean is not needed:
https://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
And I guess you need this package only for F-13+.
Thanks for the comments!
--libdir=%{_datadir} sounds like a good idea. I was worried about pkgconfig files, having only seen them deposited in %{_libdir}/pkgconfig before, but you're of course right.
Will fix the timestamp too.
I'm currently at work, but I'll get the updated package later today.
Package updated: Spec URL: http://salimma.fedorapeople.org/specs/gnome/gnome-js-common.spec SRPM URL: http://salimma.fedorapeople.org/specs/gnome/gnome-js-common-0.1.2-2.fc13.src.rpm 1 comment and 1 issue
! BuildRoot tag is also no longer needed (since Fedora 10)
* Please don't use %{minor_ver} macro in %changelog. This will
break things silently if you upgrade the version.
Please fix the issue above (at least for macros in %changelog)
before importing this package into Fedora.
-----------------------------------------------------------
This package (gnome-js-common) is APPROVED by mtasaka
-----------------------------------------------------------
Thanks; duly noted. The changelog is auto-generated from Emacs' rpm mode; I'll probably drop it. Odd that Emacs properly expand %{major_ver} though!
New Package CVS Request
=======================
Package Name: gnome-js-common
Short Description: Common modules for GNOME JavaScript interpreters
Owners: salimma
Branches: F-13
InitialCC:
CVS done (by process-cvs-requests.py). gnome-js-common-0.1.2-3.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/gnome-js-common-0.1.2-3.fc13 Closing. gnome-js-common-0.1.2-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |