Bug 600638 - Review Request: seed - GNOME JavaScript interpreter
Summary: Review Request: seed - GNOME JavaScript interpreter
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All Linux
Target Milestone: ---
Assignee: Mamoru TASAKA
QA Contact: Fedora Extras Quality Assurance
Depends On: 600637
Blocks: 577684
TreeView+ depends on / blocked
Reported: 2010-06-05 10:51 UTC by Michel Alexandre Salim
Modified: 2010-07-05 22:08 UTC (History)
3 users (show)

Fixed In Version: seed-2.30.0-2.fc13
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2010-06-22 21:17:56 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mtasaka: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)
mock log for rawhide (161.14 KB, text/plain)
2010-06-11 16:10 UTC, Mamoru TASAKA
no flags Details

Description Michel Alexandre Salim 2010-06-05 10:51:10 UTC
Spec URL: http://salimma.fedorapeople.org/specs/gnome/seed.spec
SRPM URL: http://salimma.fedorapeople.org/specs/gnome/seed-2.30.0-1.fc13.src.rpm
Seed is a library and interpreter, dynamically bridging (through
GObjectIntrospection) the WebKit JavaScriptCore engine, with the GNOME
platform. Seed serves as something which enables you to write
standalone applications in JavaScript, or easily enable your
application to be extensible in JavaScript.

Comment 1 Michel Alexandre Salim 2010-06-05 10:52:13 UTC
This depends on the review of gnome-js-common, and blocks the re-inclusion of same-gnome (now called swell foop) from GNOME Games

Comment 2 Mamoru TASAKA 2010-06-11 16:10:07 UTC
Created attachment 423325 [details]
mock log for rawhide

Some notes:

! Latest version
  - The latest version seems 2.31.0, however for now I will review
    2.30.0 because you probably import stable version into F-13.

* Cleanups
  - For BuildRoot, %clean section, please check my comment on
    bug 600637.

* BR
  - Your srpm won't build without additional
    "BR: intltool dbus-glib-devel". Plase see attached.

* rpath
  - As written in 
    use rpath "as a last resort" (i.e. avoid using rpath as much as

  ! Note
    - Usually the reason that unneeded rpath /usr/lib64 is added to
      the rebuilt binary is that the upstream developer uses libtool
      which does not take special care of /usr/lib64 for
      sys_lib_dlsearch_path_spec, while Fedora's libtool take care of
      this by adding a patch. See the below patch:

      So actually for most cases, the case that rpath /usr/lib64 is added
      (only for 64 bits arch) can be avoided by
sed -i.libdir_syssearch -e \
  '/sys_lib_dlsearch_path_spec/s|/usr/lib |/usr/lib /usr/lib64 /lib /lib64 |' \
      i.e. just add the needed paths to sys_lib_dlsearch_path_spec in
      configure (note that libtool in the build directory is generated by
      configure) before calling %configure.
      - You can alternatively do "autoreconf -fi", however calling autotools
        is not recommended unless unavoidable.

* Make build.log more verbosely
  - Currently build logs for linkage or so are suppressed. Please add
    "V=1" to "make %{?_smp_mflags}" to show more verbose log.

* Cflags
  - Fedora specific compilation flags are not honored correctly.

    configure{,ac} shows that environ-specified CFLAGS is replaced.
    For this package this can be fixed by below, for example:
sed -i.cflags -e \
	's|^\([ \t][ \t]*\)CFLAGS="[^\$].*$|\1true|' \

* Timestamps
  - As I wrote in bug 600637, please consider to keep timestamps on
    installed files as much as possible with
make install DESTDIR=$RPM_BUILD_ROOT DESTDIR="install -p"
    This method usually works for makefiles generated by recent

* %doc in -doc subpackage
  - Usually I think %doc attribute in -doc subpackage is just
    redundant because the rpm name already said it is for

  ! Note that the files / etc under %_datadir/gtk-doc is
    automatically marked as %doc, so explicit %doc for
    %{_datadir}/gtk-doc/html/seed is anyway redundant.

Comment 3 Mamoru TASAKA 2010-06-18 16:33:49 UTC
Would you update this package?

Comment 4 Michel Alexandre Salim 2010-06-18 16:48:48 UTC
Yup. Was waiting for the gnome-js-common review to clear, sorry.

Comment 5 Michel Alexandre Salim 2010-06-18 18:40:10 UTC
Updated SRPM:

Koji build (F-14 -- gnome-js-common not in stable updates yet):

Comment 6 Mamoru TASAKA 2010-06-19 15:18:43 UTC

  This package (seed) is APPROVED by mtasaka

Comment 7 Michel Alexandre Salim 2010-06-19 22:02:15 UTC
Thanks, Mamoru!

New Package CVS Request
Package Name: seed
Short Description: GNOME JavaScript interpreter
Owners: salimma
Branches: F-13

Comment 8 Kevin Fenzi 2010-06-21 02:15:14 UTC
CVS done (by process-cvs-requests.py).

Comment 9 Michel Alexandre Salim 2010-06-22 21:17:56 UTC
2.31.1 has been built for Rawhide; 2.30.0 will be built for F-13 when gnome-js-common reaches stable updates

Comment 10 Mamoru TASAKA 2010-06-23 04:44:00 UTC
You can request rel-eng team to get gnome-js-common tagged as

Comment 11 Michel Alexandre Salim 2010-06-23 09:37:36 UTC
I could, but it's been in testing long enough that it can be normally pushed to -stable anyway.

Comment 12 Fedora Update System 2010-06-23 18:15:59 UTC
seed-2.30.0-2.fc13 has been submitted as an update for Fedora 13.

Comment 13 Fedora Update System 2010-07-05 22:08:51 UTC
seed-2.30.0-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.