Bug 601274 (CVE-2010-2065)
| Summary: | CVE-2010-2065 libtiff: TIFFroundup() integer overflow in TIFFFillStrip() | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Other] Security Response | Reporter: | Tomas Hoger <thoger> | ||||||||
| Component: | vulnerability | Assignee: | Red Hat Product Security <security-response-team> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | |||||||||
| Severity: | medium | Docs Contact: | |||||||||
| Priority: | medium | ||||||||||
| Version: | unspecified | CC: | security-response-team, tgl | ||||||||
| Target Milestone: | --- | Keywords: | Security | ||||||||
| Target Release: | --- | ||||||||||
| Hardware: | All | ||||||||||
| OS: | Linux | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2010-07-07 09:23:04 UTC | Type: | --- | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 606708 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Tomas Hoger
2010-06-07 15:31:09 UTC
Created attachment 422062 [details]
Possible fix
This patch is inspired by libtiff 4.0 code. It does not do TIFFroundup() in TIFFFillStrip() (and TIFFFillTile()), as it's done in TIFFReadBufferSetup() anyway. Patch adds TIFFroundup() return value check to TIFFReadBufferSetup().
Created attachment 422514 [details]
Upstream patch
This fix got committed upstream.
Statement: Not vulnerable. These issues did not affect the versions of libtiff as shipped with Red Hat Enterprise Linux 3, 4, or 5. Created attachment 422624 [details] Updated upstream patch Avoids malloc call completely in case of integer overflow in a similar way patch in comment #2 does. Have we got an actual reproducer test case for this? None of the standard libtiff tools crash on this image on my x86_64 box. Perhaps the problem is 32-bit-only? (In reply to comment #7) > Have we got an actual reproducer test case for this? None of the standard > libtiff tools crash on this image on my x86_64 box. Perhaps the problem is > 32-bit-only? Sorry, I failed to be more clear here. No, I was not able to reproduce with libtiff tools, but this should be reproducible with gtk-based image viewers (e.g. eog or gqview) on both 32 and 64 bits. libtiff tools seem to use mmaped files, so they follow different if-else branch in TIFFFillStrip. (In reply to comment #5) > Created an attachment (id=422624) [details] > Updated upstream patch This patch is included in libtiff 3.9.3. Opening bug, fix is included in tiff 3.9.3, original launchpad bug is public now too. libtiff-3.9.4-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/libtiff-3.9.4-1.fc12 libtiff-3.9.4-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/libtiff-3.9.4-1.fc13 libtiff-3.9.4-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. libtiff-3.9.4-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |