Bug 603640
| Summary: | Review Request: python-compositor - A simple OpenType GSUB and GPOS engine | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Parag Nemade <pnemade> |
| Component: | Package Review | Assignee: | Thomas Spura <tomspur> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, i18n-bugs, notting, supercyper1, tomspur |
| Target Milestone: | --- | Keywords: | i18n |
| Target Release: | --- | Flags: | tomspur:
fedora-review+
kevin: fedora-cvs+ |
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-07-26 06:06:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 603634 | ||
| Bug Blocks: | |||
|
Description
Parag Nemade
2010-06-14 08:47:37 UTC
It'll be better to rename this package to python-$NAME to match package naming guideline. See http://fedoraproject.org/wiki/PackageNamingGuidelines#Addon_Packages_.28python_modules.29 Following the python naming guidelines now. Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/python-compositor.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/python-compositor-0.2b-1.fc13.src.rpm Review:
Good:
- name ok
- source match upstream: 932993d25d981426de3d0379880e19b4
- no *.la
- no libs
- no locales
- $ rpmlint ./noarch/python-compositor-0.2b-1.fc13.noarch.rpm ./python-compositor-0.2b-1.fc13.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
- license ok
- %files ok
- %doc ok
Needswork:
- missing R: fonttools again ;)
- %{version} in url
________________________________________________________________________________
missing fonttools as R is a BLOCKER, rest is SHOULD.
________________________________________________________________________________
APPROVED
A forgot to add: Development/Tools would be better for group Updated as Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/python-compositor.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/python-compositor-0.2b-2.fc13.src.rpm Thanks for the review! New Package CVS Request ======================= Package Name: python-compositor Short Description: A simple OpenType GSUB and GPOS engine Owners: pnemade Branches: F-13 EL-6 InitialCC: i18n-team fonts-sig CVS done (by process-cvs-requests.py). Built in rawhide. awaiting for fonttools in EPEL6 which will allow to build python-robofab and then this package in EPEL6. |