Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/compositor.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/compositor-0.2b-1.fc13.src.rpm Description: A simple OpenType GSUB and GPOS engine.
It'll be better to rename this package to python-$NAME to match package naming guideline. See http://fedoraproject.org/wiki/PackageNamingGuidelines#Addon_Packages_.28python_modules.29
Following the python naming guidelines now. Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/python-compositor.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/python-compositor-0.2b-1.fc13.src.rpm
Review: Good: - name ok - source match upstream: 932993d25d981426de3d0379880e19b4 - no *.la - no libs - no locales - $ rpmlint ./noarch/python-compositor-0.2b-1.fc13.noarch.rpm ./python-compositor-0.2b-1.fc13.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. - license ok - %files ok - %doc ok Needswork: - missing R: fonttools again ;) - %{version} in url ________________________________________________________________________________ missing fonttools as R is a BLOCKER, rest is SHOULD. ________________________________________________________________________________ APPROVED
A forgot to add: Development/Tools would be better for group
Updated as Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/python-compositor.spec SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/python-compositor-0.2b-2.fc13.src.rpm
Thanks for the review! New Package CVS Request ======================= Package Name: python-compositor Short Description: A simple OpenType GSUB and GPOS engine Owners: pnemade Branches: F-13 EL-6 InitialCC: i18n-team fonts-sig
CVS done (by process-cvs-requests.py).
Built in rawhide. awaiting for fonttools in EPEL6 which will allow to build python-robofab and then this package in EPEL6.