Bug 603640 - Review Request: python-compositor - A simple OpenType GSUB and GPOS engine
Summary: Review Request: python-compositor - A simple OpenType GSUB and GPOS engine
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review   
(Show other bugs)
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Thomas Spura
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Keywords: i18n
Depends On: 603634
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-06-14 08:47 UTC by Parag Nemade
Modified: 2010-07-26 06:06 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-07-26 06:06:42 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tomspur: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Parag Nemade 2010-06-14 08:47:37 UTC
Spec URL: http://paragn.fedorapeople.org/fedora-work/SPECS/compositor.spec
SRPM URL: http://paragn.fedorapeople.org/fedora-work/SRPMS/compositor-0.2b-1.fc13.src.rpm
Description: 
A simple OpenType GSUB and GPOS engine.

Comment 1 Chen Lei 2010-06-14 09:23:08 UTC
It'll be better to rename this package to python-$NAME to match package naming guideline.

See
http://fedoraproject.org/wiki/PackageNamingGuidelines#Addon_Packages_.28python_modules.29

Comment 3 Thomas Spura 2010-07-22 15:13:55 UTC
Review:

Good:
- name ok
- source match upstream: 932993d25d981426de3d0379880e19b4
- no *.la
- no libs
- no locales
- $ rpmlint ./noarch/python-compositor-0.2b-1.fc13.noarch.rpm ./python-compositor-0.2b-1.fc13.src.rpm 
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
- license ok
- %files ok
- %doc ok



Needswork:
- missing R: fonttools again ;)
- %{version} in url


________________________________________________________________________________

missing fonttools as R is a BLOCKER, rest is SHOULD.
________________________________________________________________________________

APPROVED

Comment 4 Thomas Spura 2010-07-22 15:17:11 UTC
A forgot to add:
Development/Tools would be better for group

Comment 6 Parag Nemade 2010-07-23 05:05:48 UTC
Thanks for the review!

New Package CVS Request
=======================
Package Name: python-compositor
Short Description: A simple OpenType GSUB and GPOS engine
Owners: pnemade
Branches: F-13 EL-6
InitialCC: i18n-team fonts-sig

Comment 7 Kevin Fenzi 2010-07-23 21:36:04 UTC
CVS done (by process-cvs-requests.py).

Comment 8 Parag Nemade 2010-07-26 06:06:42 UTC
Built in rawhide. awaiting for fonttools in EPEL6 which will allow to build python-robofab and then this package in EPEL6.


Note You need to log in before you can comment on or make changes to this bug.