Bug 603799

Summary:	If a system that I own is a available in Beaker, there can be an instance when I can accidentally "return" it on a developer that has reserved that system.
Product:	[Retired] Beaker	Reporter:	PaulB <pbunyan>
Component:	lab controller	Assignee:	Bill Peck <bpeck>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	low
Version:	0.5	CC:	bpeck, dcallagh, jburke, kbaker, mcsontos, pbunyan, rmancy
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-07-13 12:49:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description PaulB 2010-06-14 15:35:59 UTC

Description of problem:
If a system that I own is a available in Beaker, there can be an instance when I can accidentally "return" it on a developer that has reserved that system.

If I check the availability of a system in Beaker and pause before I actually "take" the system, another developer may "take" the system seconds before me.
If I then click the "take" link, I actually "return" the system from the developer that has reserved it.

Yes, a page refresh would show that the developer has taken the system. However, If I don't refresh the page, I will accidentally return the system on the developer.

Version-Release number of selected component (if applicable):

Steps to Reproduce:
1. Check the availability of a system that you own.
2. Have someone else, with permission on the system, "take" that system.
3. You then "take" the system
4. You end up "returning" the system from the developer.
  
Actual results:
You have no idea the other developer has "taken" the system in the short time frame. When you click "take" on your screen you actually return the system from the other developer.

Expected results:
I should not be able to accidentally "return" a system from a developer.

We may need a window that pops up and asks:
"Are you sure you wish to return this reserved system"
Something similar to the reboot confirmation.
As without this pop up, you have no idea someone else has reserved the system in this small window of time.

Additional info:
We may need a window that pops up and asks:
"Are you sure you wish to return this reserved system"
Something similar to the reboot confirmation.
As without this pop up, you have no idea someone else has reserved the system in this small window of time.

Best,
-pbunyan