Bug 604438

Summary: Review Request: rubygem-scaffold - Scaffold is a templating tool for Puppet
Product: [Fedora] Fedora Reporter: Michael Stahnke <mastahnke>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, mtasaka, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-07-06 21:35:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Michael Stahnke 2010-06-15 21:42:21 UTC
Spec URL: http://stahnma.fedorapeople.org/reviews/rubygem-scaffold.spec
SRPM URL: http://stahnma.fedorapeople.org/reviews/rubygem-scaffold-0.0.3-1.fc14.src.rpm
Scaffold allows you to create basic Puppet configuration, modules, nodes,
classes, functions and types.

Comment 1 Mamoru TASAKA 2010-06-25 18:27:07 UTC
Some notes:

* %define -> %global
  - Now we prefer to use %global rather than %define

* ruby(abi) dependency
  - Writing ruby(abi) dependency is a must

* Explcitly defined macros
  - Explicitly defined %ruby_sitelib is used nowhere.
  - Please use explicitly defined %geminstdir also in %files

* Explicit version dependency
  - As rubygem-templater in Fedora on all supported branches have higher version
    than 0.5.0, the explicit ">= 0.5.0" part is not needed, ref:

* BuildRoot tag
  - BuildRoot tag is no longer used so you can remove this (although rpmlint may
    complain) on Fedora (not on EPEL)

! %changelog
  - Please also write your name.

Comment 2 Michael Stahnke 2010-06-28 20:23:41 UTC
I must have submitted the gem2rpm spec and not the final one I cleaned up. :)  I'm out of town until the end of the week, so I will look at it then.

Comment 3 Michael Stahnke 2010-07-06 21:35:09 UTC
I'd like to withdraw this request. Upstream is going to replace it with another tool shortly.