Bug 604710

Summary:	Create new bundle: "Previous" button enabled on failed file upload
Product:	[Other] RHQ Project	Reporter:	Corey Welton <cwelton>
Component:	Core UI	Assignee:	Jay Shaughnessy <jshaughn>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sunil Kondkar <skondkar>
Severity:	medium	Docs Contact:
Priority:	urgent
Version:	1.4	CC:	jshaughn
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	2.4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-08-12 16:44:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	577210

Description Corey Welton 2010-06-16 14:51:27 UTC

Description of problem:
After a failed upload of a package for a bundle, the "previous" button in the wizard is enabled.  This is clickable, and while it does not appear to take user anywhere, the "step" count gets messed up.

Version-Release number of selected component (if applicable):


How reproducible:
Every time.

Steps to Reproduce:
1.  Initiate bundle creation wizard.  
2.  Click the "Upload" radio button
3.  from your file picker, submit a file that is invalid.  At very least, do something as noted in bug #601175 that results in a bad file.
4.  Click the "Next" button.  Note of course that the upload fails.
5.  Observe Previous button.   Click this button a half dozen times.
6.  Note the "Step x of y" indicator at top of wizard

Actual results:
* Previous button lights up despite failed upload
* Previous button can be clicked, messing up the "Step x of y" counter, i.e., "Step -5 of 3"



Expected results:


Additional info:

Comment 1 Jay Shaughnessy 2010-07-07 19:56:01 UTC

fix commit: 91c9d1fb7849b9966f60a2cdeb8bca1903e3389c

This was an issue in the Wizard framework, which I've fixed.  Moreover in this particular wizard step I disable the Previous button as needed.

Comment 2 Sunil Kondkar 2010-07-08 11:28:44 UTC

Verified on jon-2.4.0.GA_QA build#52

After a failed upload of a bundle, the "previous" button in the wizard is disabled.

Comment 3 Corey Welton 2010-08-12 16:44:11 UTC

Mass-closure of verified bugs against JON.