Bug 605859

Summary:	Review Request: python-eggtestinfo - Python setuptools plugin for adding test information to .egg-info
Product:	[Fedora] Fedora	Reporter:	Nathaniel McCallum <nathaniel>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED INSUFFICIENT_DATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, mail, mrunge, notting
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:	StalledSubmitter
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-02-27 15:12:20 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Nathaniel McCallum 2010-06-18 23:43:40 UTC

Spec URL: http://nathaniel.themccallums.org/rpms/python-eggtestinfo.spec
SRPM URL: http://nathaniel.themccallums.org/rpms/python-eggtestinfo-0.2.2-1.fc13.src.rpm
Description:
This package is a setuptools plugin: it adds
a file to the generated .egg-info directory,
capturing the information used by the setup.py
test command when running tests.

Comment 1 Fabian Affolter 2010-07-04 12:24:06 UTC

Some quick comments on your spec file:

[fab@laptop011 SRPMS]$ rpmlint python-eggtestinfo-0.2.2-1.fc13.src.rpm 
python-eggtestinfo.src: W: spelling-error Summary(en_US) setuptools -> setup tools, setup-tools, setups
python-eggtestinfo.src: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging
python-eggtestinfo.src: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, setups
python-eggtestinfo.src: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging
python-eggtestinfo.src: W: invalid-license Python Software Foundation License
python-eggtestinfo.src: W: invalid-license Zope Public License
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

- Please fix the license tag.
- Using macros in the URL is not very useful for copy-and-paste 
  From my point of view the url can be http://pypi.python.org/pypi/eggtestinfo
- If you want to build this package for Fedora 12 please use this %{python_sitelib} macros
  https://fedoraproject.org/wiki/Packaging:Python#Macros

Comment 2 Nathaniel McCallum 2010-07-05 20:23:24 UTC

What is the proper license name?  I've tried all combinations of PSFL/Python/etc.  Same for ZPL/ZPLv2/etc.  rpmlint always seems to complain no matter what I put.

Comment 3 Fabian Affolter 2010-07-05 20:57:44 UTC

As far as I can see the the license short name for the license tag should be: "Python or ZPLv1.0" for those licenses.

Another issue is that upstream only make a vague statement about the license.  There is no license statement in the source header and there is no license file in the source tarball.  Only a statement on the website.  This can become a blocker.

Comment 4 Jason Tibbitts 2010-11-23 19:08:50 UTC

Was the license issue ever clarified?

This package also needs updating to the current python packaging guidelines.

Comment 5 Fabian Affolter 2011-03-31 19:12:33 UTC

The latest release is 0.3