Red Hat Bugzilla – Bug 605859
Review Request: python-eggtestinfo - Python setuptools plugin for adding test information to .egg-info
Last modified: 2012-02-27 10:12:20 EST
Spec URL: http://nathaniel.themccallums.org/rpms/python-eggtestinfo.spec SRPM URL: http://nathaniel.themccallums.org/rpms/python-eggtestinfo-0.2.2-1.fc13.src.rpm Description: This package is a setuptools plugin: it adds a file to the generated .egg-info directory, capturing the information used by the setup.py test command when running tests.
Some quick comments on your spec file: [fab@laptop011 SRPMS]$ rpmlint python-eggtestinfo-0.2.2-1.fc13.src.rpm python-eggtestinfo.src: W: spelling-error Summary(en_US) setuptools -> setup tools, setup-tools, setups python-eggtestinfo.src: W: spelling-error Summary(en_US) plugin -> plug in, plug-in, plugging python-eggtestinfo.src: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, setups python-eggtestinfo.src: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging python-eggtestinfo.src: W: invalid-license Python Software Foundation License python-eggtestinfo.src: W: invalid-license Zope Public License 1 packages and 0 specfiles checked; 0 errors, 6 warnings. - Please fix the license tag. - Using macros in the URL is not very useful for copy-and-paste From my point of view the url can be http://pypi.python.org/pypi/eggtestinfo - If you want to build this package for Fedora 12 please use this %{python_sitelib} macros https://fedoraproject.org/wiki/Packaging:Python#Macros
What is the proper license name? I've tried all combinations of PSFL/Python/etc. Same for ZPL/ZPLv2/etc. rpmlint always seems to complain no matter what I put.
As far as I can see the the license short name for the license tag should be: "Python or ZPLv1.0" for those licenses. Another issue is that upstream only make a vague statement about the license. There is no license statement in the source header and there is no license file in the source tarball. Only a statement on the website. This can become a blocker.
Was the license issue ever clarified? This package also needs updating to the current python packaging guidelines.
The latest release is 0.3