Bug 605993

Summary:	Review Request: python-mglob - Enhanced file name globbing module
Product:	[Fedora] Fedora	Reporter:	Thomas Spura <tomspur>
Component:	Package Review	Assignee:	Chen Lei <supercyper1>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting, supercyper1
Target Milestone:	---	Flags:	supercyper1: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	python-mglob-0.4-1.fc12	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-06-21 21:30:25 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	603937

Description Thomas Spura 2010-06-19 20:33:37 UTC

Spec URL: http://tomspur.fedorapeople.org/review/mglob.spec
SRPM URL: http://tomspur.fedorapeople.org/review/mglob-0.4-1.fc13.src.rpm

Description:
Usable as stand-alone utility (for xargs, backticks etc.), or as a globbing
library for own python programs.
Some enhanced features are recursion, exclusion, and directory omission.


##############################################################################

rpmlint contains several (I think wrong) spelling-errors and:
mglob.noarch: W: no-documentation
mglob.noarch: W: no-manual-page-for-binary mglob

That should be fixed upstream and not while the review process, so I opened an issue upstream about this:
http://code.google.com/p/vvtools/issues/detail?id=1


This package is needed for ipython, which currently contains this as a bundled library.

Comment 1 Thomas Spura 2010-06-19 20:49:48 UTC

I choosed to rename it to python-mglob like other python modules.

Spec URL: http://tomspur.fedorapeople.org/review/python-mglob.spec
SRPM URL: http://tomspur.fedorapeople.org/review/python-mglob-0.4-1.fc13.src.rpm

Comment 2 Chen Lei 2010-06-20 12:22:03 UTC

rpmlint python-mglob-0.4-1.fc14.noarch.rpm 
python-mglob.noarch: W: spelling-error Summary(en_US) globbing -> globing, gobbing, lobbing
python-mglob.noarch: W: spelling-error %description -l en_US xargs -> Argus, Argos, argals
python-mglob.noarch: W: spelling-error %description -l en_US backticks -> back ticks, back-ticks, backtracks
python-mglob.noarch: W: spelling-error %description -l en_US globbing -> globing, gobbing, lobbing
python-mglob.noarch: W: no-documentation
python-mglob.noarch: W: no-manual-page-for-binary mglob
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

All can be ignored.

mdsum matches upstream tarball
3d875720611ff4e73b402376e2b48f1b mglob-0.4.zip

I suggest using python instead of %{__python} in python guideline, because __* macros are rarely documented in all other fedora packging guidelines.

rpm --eval %__python
/usr/bin/python

rpm --eval %__rm
/bin/rm

Comment 3 Chen Lei 2010-06-20 12:22:25 UTC

This package is approved.

Comment 4 Thomas Spura 2010-06-20 12:59:05 UTC

Thanks for the fast review again :)

(In reply to comment #2)
> I suggest using python instead of %{__python} in python guideline, because __*
> macros are rarely documented in all other fedora packging guidelines.
> 
> rpm --eval %__python
> /usr/bin/python
> 
> rpm --eval %__rm
> /bin/rm    

It's often used e.g. in:
https://fedoraproject.org/wiki/Packaging:Python

I guess almost every python program uses %{__python} instead of just python, because rpmdev-newspec is proposing this...

I think, it would be inconsistend to use simply 'python'. Maybe the packaging commitee can decide something new, to not use such macros anymore...

Comment 5 Thomas Spura 2010-06-20 12:59:59 UTC

New Package CVS Request
=======================
Package Name: python-mglob
Short Description: Enhanced file name globbing module
Owners: tomspur
Branches: F-12 F-13 EL-5 EL-6
InitialCC:

Comment 6 Chen Lei 2010-06-20 13:19:44 UTC

(In reply to comment #4)
> Thanks for the fast review again :)
> (In reply to comment #2)
> > I suggest using python instead of %{__python} in python guideline, because __*
> > macros are rarely documented in all other fedora packging guidelines.
> > 
> > rpm --eval %__python
> > /usr/bin/python
> > 
> > rpm --eval %__rm
> > /bin/rm    
> It's often used e.g. in:
> https://fedoraproject.org/wiki/Packaging:Python
> I guess almost every python program uses %{__python} instead of just python,
> because rpmdev-newspec is proposing this...
> I think, it would be inconsistend to use simply 'python'. Maybe the packaging
> commitee can decide something new, to not use such macros anymore...    

I guess packaging python guideline is the only place to use those __* macros :)

Comment 7 Kevin Fenzi 2010-06-21 02:32:24 UTC

CVS done (by process-cvs-requests.py).

Comment 8 Fedora Update System 2010-06-21 08:28:12 UTC

python-mglob-0.4-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/python-mglob-0.4-1.fc13

Comment 9 Fedora Update System 2010-06-21 08:28:17 UTC

python-mglob-0.4-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/python-mglob-0.4-1.fc12

Comment 10 Fedora Update System 2010-06-21 21:30:19 UTC

python-mglob-0.4-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2010-06-21 21:34:40 UTC

python-mglob-0.4-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.