Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://tomspur.fedorapeople.org/review/mglob.spec SRPM URL: http://tomspur.fedorapeople.org/review/mglob-0.4-1.fc13.src.rpm Description: Usable as stand-alone utility (for xargs, backticks etc.), or as a globbing library for own python programs. Some enhanced features are recursion, exclusion, and directory omission. ############################################################################## rpmlint contains several (I think wrong) spelling-errors and: mglob.noarch: W: no-documentation mglob.noarch: W: no-manual-page-for-binary mglob That should be fixed upstream and not while the review process, so I opened an issue upstream about this: http://code.google.com/p/vvtools/issues/detail?id=1 This package is needed for ipython, which currently contains this as a bundled library.
I choosed to rename it to python-mglob like other python modules. Spec URL: http://tomspur.fedorapeople.org/review/python-mglob.spec SRPM URL: http://tomspur.fedorapeople.org/review/python-mglob-0.4-1.fc13.src.rpm
rpmlint python-mglob-0.4-1.fc14.noarch.rpm python-mglob.noarch: W: spelling-error Summary(en_US) globbing -> globing, gobbing, lobbing python-mglob.noarch: W: spelling-error %description -l en_US xargs -> Argus, Argos, argals python-mglob.noarch: W: spelling-error %description -l en_US backticks -> back ticks, back-ticks, backtracks python-mglob.noarch: W: spelling-error %description -l en_US globbing -> globing, gobbing, lobbing python-mglob.noarch: W: no-documentation python-mglob.noarch: W: no-manual-page-for-binary mglob 1 packages and 0 specfiles checked; 0 errors, 6 warnings. All can be ignored. mdsum matches upstream tarball 3d875720611ff4e73b402376e2b48f1b mglob-0.4.zip I suggest using python instead of %{__python} in python guideline, because __* macros are rarely documented in all other fedora packging guidelines. rpm --eval %__python /usr/bin/python rpm --eval %__rm /bin/rm
This package is approved.
Thanks for the fast review again :) (In reply to comment #2) > I suggest using python instead of %{__python} in python guideline, because __* > macros are rarely documented in all other fedora packging guidelines. > > rpm --eval %__python > /usr/bin/python > > rpm --eval %__rm > /bin/rm It's often used e.g. in: https://fedoraproject.org/wiki/Packaging:Python I guess almost every python program uses %{__python} instead of just python, because rpmdev-newspec is proposing this... I think, it would be inconsistend to use simply 'python'. Maybe the packaging commitee can decide something new, to not use such macros anymore...
New Package CVS Request ======================= Package Name: python-mglob Short Description: Enhanced file name globbing module Owners: tomspur Branches: F-12 F-13 EL-5 EL-6 InitialCC:
(In reply to comment #4) > Thanks for the fast review again :) > (In reply to comment #2) > > I suggest using python instead of %{__python} in python guideline, because __* > > macros are rarely documented in all other fedora packging guidelines. > > > > rpm --eval %__python > > /usr/bin/python > > > > rpm --eval %__rm > > /bin/rm > It's often used e.g. in: > https://fedoraproject.org/wiki/Packaging:Python > I guess almost every python program uses %{__python} instead of just python, > because rpmdev-newspec is proposing this... > I think, it would be inconsistend to use simply 'python'. Maybe the packaging > commitee can decide something new, to not use such macros anymore... I guess packaging python guideline is the only place to use those __* macros :)
CVS done (by process-cvs-requests.py).
python-mglob-0.4-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python-mglob-0.4-1.fc13
python-mglob-0.4-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/python-mglob-0.4-1.fc12
python-mglob-0.4-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
python-mglob-0.4-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.