Bug 607227

Summary:	Stopped systemtap initscript does not start on 'restart'
Product:	Red Hat Enterprise Linux 6	Reporter:	Petr Muller <pmuller>
Component:	systemtap	Assignee:	Frank Ch. Eigler <fche>
Status:	CLOSED ERRATA	QA Contact:	qe-baseos-tools-bugs
Severity:	medium	Docs Contact:
Priority:	low
Version:	6.1	CC:	jeast, mjw, ohudlick, rlandman, syeghiay
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	systemtap-1.4-2.el6	Doc Type:	Bug Fix
Doc Text:	Previously, the code for starting, stopping, and restarting systemtap was defined in systemtap's own initscript rather than using the globally defined behaviors on the system. Systemtap's own handling of the 'restart' action did not start systemtap if it was not already running. This updated package copies the $SCRIPTS global scripts as a basis for its initscript actions. The 'restart' action therefore has the same default behaviour as other initscripts on the system and additionally now honors the 'force-reload', 'reload', 'condrestart' and 'try-restart' actions.	Story Points:	---
Clone Of:
Clones:	607232 (view as bug list)		Environment:
Last Closed:	2011-05-19 13:54:31 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Muller 2010-06-23 14:43:36 UTC

Description of problem:

systemtap service from systemtap-initscript service does not beahve as required in https://fedoraproject.org/wiki/Packaging/SysVInitScript (the guideline is from Fedora, but it valid for RHEL too)

===============================================================================
All SysV-style initscripts in Fedora must have implementations of the following actions:
(...)
    * restart: stop and restart the service if the service is already running, otherwise just start the service
(...)
===============================================================================


Version-Release number of selected component (if applicable):
systemtap-1.2-3.el6

How reproducible:
always

Steps to Reproduce:
1. cp heart.stp /etc/systemtap/script.d/
2. service systemtap stop
3. service systemtap restart
  
Actual results:
# service systemtap restart
Starting systemtap:                                        [WARNING]
# service systemtap status
heart is stopped

Expected results:
# service systemtap restart
Starting systemtap:  Starting heart ... done
# service systemtap status
heart is running...

Comment 2 RHEL Program Management 2010-06-23 15:12:52 UTC

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux major release.  Product Management has requested further
review of this request by Red Hat Engineering, for potential inclusion in a Red
Hat Enterprise Linux Major release.  This request is not yet committed for
inclusion.

Comment 3 RHEL Program Management 2010-07-15 14:49:38 UTC

This issue has been proposed when we are only considering blocker
issues in the current Red Hat Enterprise Linux release. It has
been denied for the current Red Hat Enterprise Linux release.

** If you would still like this issue considered for the current
release, ask your support representative to file as a blocker on
your behalf. Otherwise ask that it be considered for the next
Red Hat Enterprise Linux release. **

Comment 4 Frank Ch. Eigler 2010-11-22 21:11:05 UTC

Upstream commit 3c56839 fixed this for rhel5.6 and later.

Comment 11 Ruediger Landmann 2011-05-18 03:23:00 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Previously, the code for starting, stopping, and restarting systemtap 
was defined in systemtap's own initscript rather than using the globally
defined behaviors on the system. Systemtap's own handling of the 
'restart' action did not start systemtap if it was not already running.
This updated package copies the $SCRIPTS global scripts as a basis 
for its initscript actions. The 'restart' action therefore has the same
default behaviour as other initscripts on the system and dditionally
now honors the 'force-reload', 'reload', 'condrestart' and 'try-restart' 
actions.

Comment 12 Ruediger Landmann 2011-05-18 05:09:35 UTC

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -4,6 +4,6 @@
 'restart' action did not start systemtap if it was not already running.
 This updated package copies the $SCRIPTS global scripts as a basis 
 for its initscript actions. The 'restart' action therefore has the same
-default behaviour as other initscripts on the system and dditionally
+default behaviour as other initscripts on the system and additionally
 now honors the 'force-reload', 'reload', 'condrestart' and 'try-restart' 
 actions.

Comment 13 errata-xmlrpc 2011-05-19 13:54:31 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0651.html