Bug 608461

Summary: measurement units incorrect for "query execution max time" metric for hibernate plugin
Product: [Other] RHQ Project Reporter: Joseph Marques <jmarques>
Component: PluginsAssignee: Joseph Marques <jmarques>
Status: CLOSED CURRENTRELEASE QA Contact: Corey Welton <cwelton>
Severity: medium Docs Contact:
Priority: low    
Version: 3.0.0CC: ian.springer
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: 2.4 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-08-12 16:57:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 725852    
Attachments:
Description Flags
rendered metric mini-graph before the fix
none
rendered metric mini-graph AFTER the fix none

Description Joseph Marques 2010-06-27 16:43:51 UTC 
Description of problem:

The "query execution max time" metric for the hibernate statistics service is incorrect.  Looking at the plugin descriptor, the units are unspecified, which implies the system will interpret the metric as an absolute count.

The statistics mbean indicates that this value is in milliseconds.  The fix is to add the following attribute and to the metric definition in the rhq-plugin.xml file:

units="milliseconds"

The plugin metadata update processes should take care of the rest.  Since the metric graphs have their axes labels generated during rendering, it should fix the appearance of already collected data, as well as fix the appearance of all data collected in the future.

-----

Two images will be uploaded to this case, showing what the rendered metric mini-graph looks like before and after the fix.
Comment 1 Joseph Marques 2010-06-27 16:50:35 UTC 
Created attachment 427234 [details]
rendered metric mini-graph before the fix
Comment 2 Joseph Marques 2010-06-27 16:50:59 UTC 
Created attachment 427235 [details]
rendered metric mini-graph AFTER the fix
Comment 3 Joseph Marques 2010-06-27 22:19:02 UTC 
commit 942920432369b0be766ae653325678d312cda0a9
Author: Joseph Marques <joseph>
Date:   Sun Jun 27 18:09:40 2010 -0400

    BZ-608461: fix units for Hibernate statistics service "query execution max time" metric
Comment 4 Corey Welton 2010-06-30 13:52:58 UTC 
QA Verified.  the appropriate measurement unit now appears.
Comment 5 Corey Welton 2010-08-12 16:57:06 UTC 
Mass-closure of verified bugs against JON.