Bug 608461 - measurement units incorrect for "query execution max time" metric for hibernate plugin
Summary: measurement units incorrect for "query execution max time" metric for hiberna...
Status: CLOSED CURRENTRELEASE
Alias: None
Product: RHQ Project
Classification: Other
Component: Plugins (Show other bugs)
(Show other bugs)
Version: 3.0.0
Hardware: All All
low
medium vote
Target Milestone: ---
: ---
Assignee: Joseph Marques
QA Contact: Corey Welton
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: 725852
TreeView+ depends on / blocked
 
Reported: 2010-06-27 16:43 UTC by Joseph Marques
Modified: 2011-07-28 16:36 UTC (History)
1 user (show)

Fixed In Version: 2.4
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-08-12 16:57:06 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
rendered metric mini-graph before the fix (21.01 KB, image/png)
2010-06-27 16:50 UTC, Joseph Marques
no flags Details
rendered metric mini-graph AFTER the fix (21.11 KB, image/png)
2010-06-27 16:50 UTC, Joseph Marques
no flags Details

Description Joseph Marques 2010-06-27 16:43:51 UTC
Description of problem:

The "query execution max time" metric for the hibernate statistics service is incorrect.  Looking at the plugin descriptor, the units are unspecified, which implies the system will interpret the metric as an absolute count.

The statistics mbean indicates that this value is in milliseconds.  The fix is to add the following attribute and to the metric definition in the rhq-plugin.xml file:

units="milliseconds"

The plugin metadata update processes should take care of the rest.  Since the metric graphs have their axes labels generated during rendering, it should fix the appearance of already collected data, as well as fix the appearance of all data collected in the future.

-----

Two images will be uploaded to this case, showing what the rendered metric mini-graph looks like before and after the fix.

Comment 1 Joseph Marques 2010-06-27 16:50:35 UTC
Created attachment 427234 [details]
rendered metric mini-graph before the fix

Comment 2 Joseph Marques 2010-06-27 16:50:59 UTC
Created attachment 427235 [details]
rendered metric mini-graph AFTER the fix

Comment 3 Joseph Marques 2010-06-27 22:19:02 UTC
commit 942920432369b0be766ae653325678d312cda0a9
Author: Joseph Marques <joseph@redhat.com>
Date:   Sun Jun 27 18:09:40 2010 -0400

    BZ-608461: fix units for Hibernate statistics service "query execution max time" metric

Comment 4 Corey Welton 2010-06-30 13:52:58 UTC
QA Verified.  the appropriate measurement unit now appears.

Comment 5 Corey Welton 2010-08-12 16:57:06 UTC
Mass-closure of verified bugs against JON.


Note You need to log in before you can comment on or make changes to this bug.