Bug 609011
| Summary: | Review Request: derby - Relational database implemented entirely in Java | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Marek Mahut <mmahut> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 13 | CC: | akurtako, fedora-package-review, mefoster, mmahut, mzatko, notting, sebastian, sochotni |
| Target Milestone: | --- | Flags: | mmahut:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-08-18 15:20:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 609012 | ||
|
Description
Lubomir Rintel
2010-06-29 08:06:31 UTC
It would be good if you install maven poms and scripts for using tools. Also there is https://bugzilla.redhat.com/show_bug.cgi?id=532520 which is a dubplicate of this one. SPEC: http://v3.sk/~lkundrak/SPECS/derby.spec SRPM: http://v3.sk/~lkundrak/SRPMS/derby-10.6.1.0-2.fc13.src.rpm *** Bug 532520 has been marked as a duplicate of this bug. *** .--.
.' '.
/ ~~~~ \
( __ __ )
/|<o-> <o->|\ Oh noes
( | ^^ | ) people over the internets
_ ) \ __ / / adding themselves to cc
/##\ \_(__)_/ / laughing at java tools packaging
/####) )#\__// (
/####( |##| |#\ \
(#####| |##(_/##\_/\
OK - rpmlint must be run on every package. The output should be posted in the review.
OK - The package must be named according to the Package Naming Guidelines .
OK - The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
?? - The package must meet the Packaging Guidelines .
OK - The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
OK - The License field in the package spec file must match the actual license.
OK - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.[4]
OK - The spec file must be written in American English.
OK - The spec file for the package MUST be legible.
OK - The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
* Source db-derby-10.6.1.0-src.tar.gz is the same as upstream
* Source derby-10.6.1.0.pom is the same as upstream
* Source derby-project-10.6.1.0.pom is the same as upstream
* Source derbyLocale_cs-10.6.1.0.pom is the same as upstream
* Source derbyLocale_de_DE-10.6.1.0.pom is the same as upstream
* Source derbyLocale_es-10.6.1.0.pom is the same as upstream
* Source derbyLocale_fr-10.6.1.0.pom is the same as upstream
* Source derbyLocale_hu-10.6.1.0.pom is the same as upstream
* Source derbyLocale_it-10.6.1.0.pom is the same as upstream
* Source derbyLocale_ja_JP-10.6.1.0.pom is the same as upstream
* Source derbyLocale_ko_KR-10.6.1.0.pom is the same as upstream
* Source derbyLocale_pl-10.6.1.0.pom is the same as upstream
* Source derbyLocale_pt_BR-10.6.1.0.pom is the same as upstream
* Source derbyLocale_ru-10.6.1.0.pom is the same as upstream
* Source derbyLocale_zh_CN-10.6.1.0.pom is the same as upstream
* Source derbyLocale_zh_TW-10.6.1.0.pom is the same as upstream
* Source derbyclient-10.6.1.0.pom is the same as upstream
* Source derbynet-10.6.1.0.pom is the same as upstream
* Source derbytools-10.6.1.0.pom is the same as upstream
FAIL - The package MUST successfully compile and build into binary rpms on at least one primary architecture.
Does not build in koji.
See http://koji.fedoraproject.org/koji/taskinfo?taskID=2356692
build.log from mock:
/var/tmp/rpm-tmp.rd7cdF: line 53: ant: command not found
Please add ant to dependencies.
This review was informal and is incomplete.
(In reply to comment #5) > FAIL - The package MUST successfully compile and build into binary rpms on at > least one primary architecture. > > Does not build in koji. > See http://koji.fedoraproject.org/koji/taskinfo?taskID=2356692 > > build.log from mock: > /var/tmp/rpm-tmp.rd7cdF: line 53: ant: command not found > > Please add ant to dependencies. Thank you. Fixed the BRs: SPEC: http://v3.sk/~lkundrak/SPECS/derby.spec SRPM: http://v3.sk/~lkundrak/SRPMS/derby-10.6.1.0-3.fc13.src.rpm Internet People, this new package looks sane to me. APPROVED. Much thanks, Mar{ek,os} for reviewing this!
New Package SCM Request
=======================
Package Name: derby
Short Description: Relational database implemented entirely in java
Owners: lkundrak
Branches: f13 f14 el6
Git done (by process-git-requests). ______ _|___|__ ___|___|__ _|___|___|______ Imported and built. ___|___|___|___|__ _|___|___|___|___| ___|___|___|___|___| _|___|___|___|___|___ |