Bug 609012 - Review Request: gooddata-cl - GoodData integration toolkit
Review Request: gooddata-cl - GoodData integration toolkit
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
13
All Linux
low Severity medium
: ---
: ---
Assigned To: Michal Ingeli
Fedora Extras Quality Assurance
:
Depends On: 594414 594416 609011
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-29 04:08 EDT by Lubomir Rintel
Modified: 2010-11-05 14:25 EDT (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-11-05 14:25:21 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
mi: fedora‑review+
tibbs: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Lubomir Rintel 2010-06-29 04:08:31 EDT
SPEC: http://v3.sk/~lkundrak/SPECS/gooddata-cl.spec
SRPM: http://v3.sk/~lkundrak/gooddata-cli/gooddata-cl-1.0-0.1.20100628git.fc13.src.rpm

Description:

This is GoodData data integration toolkit. The toolkit contains data
modeling, transformation and loading utilities that work on top of the
GoodData REST APIs.
Comment 1 Lubomir Rintel 2010-06-29 04:09:22 EDT
Builds only in Fedora 14 now. The complete stack with necessary dependencies runnable on Fedora 13 is here: http://v3.sk/~lkundrak/gooddata-cli/
Comment 4 R P Herrold 2010-09-21 11:09:48 EDT
the URL in the .spec file returns a dead link -- perhaps replace it with: http://developer.gooddata.com/

-- Russ herrold
Comment 5 Michal Ingeli 2010-11-04 11:58:26 EDT
* description and spec file clean, no useless comments

- URL contains a dead link.
- Project name and package name consistency GoodData-CL Vs. gooddata-cl
- Build failed for f13 [1] and also f14 [2]. 
- rpmlint errors:

  gooddata-cl.src: W: invalid-url Source0: gooddata-cl-1.1.4.tar.gz
  * sources from git repo - OK

  gooddata-cl.src: W: no-buildroot-tag
  * if this package is intended to be build for EPEL, it should contain buildroot tag.

  gooddata-cl.src: W: strange-permission gooddata-cli 0755L
  * file listed in %{_bindir}, rpmlint shouldn't be complaining

- missing BuildDeps reported by koji:

DEBUG util.py:260:  No Package Found for axis >= 1.4
DEBUG util.py:260:  No Package Found for javacc-maven-plugin
DEBUG util.py:260:  No Package Found for xpp3-minimal >= 1.1.3.8-3.4
DEBUG util.py:260:  No Package Found for xstream >= 1.3.1
DEBUG util.py:260:  No Package Found for json-lib
DEBUG util.py:260:  No Package Found for gdata-java > 1.39

[1] http://koji.fedoraproject.org/koji/taskinfo?taskID=2576436
[2] http://koji.fedoraproject.org/koji/taskinfo?taskID=2576466
Comment 6 Lubomir Rintel 2010-11-04 12:43:36 EDT
(In reply to comment #5)
> * description and spec file clean, no useless comments
> 
> - URL contains a dead link.

Fixed

> - Project name and package name consistency GoodData-CL Vs. gooddata-cl
> - Build failed for f13 [1]

F13 is too old.

and also f14 [2]. 

Fixed.

>   gooddata-cl.src: W: no-buildroot-tag
>   * if this package is intended to be build for EPEL, it should contain
> buildroot tag.

EPEL is even more ancient.

>   gooddata-cl.src: W: strange-permission gooddata-cli 0755L
>   * file listed in %{_bindir}, rpmlint shouldn't be complaining

Well this is about the Source file. Fixed.

> - missing BuildDeps reported by koji:
> 
> DEBUG util.py:260:  No Package Found for axis >= 1.4
> DEBUG util.py:260:  No Package Found for javacc-maven-plugin
> DEBUG util.py:260:  No Package Found for xpp3-minimal >= 1.1.3.8-3.4
> DEBUG util.py:260:  No Package Found for xstream >= 1.3.1
> DEBUG util.py:260:  No Package Found for json-lib
> DEBUG util.py:260:  No Package Found for gdata-java > 1.39

This is on F13. That's too old.

SPEC: http://v3.sk/~lkundrak/SPECS/gooddata-cl.spec
SRPM:
http://v3.sk/~lkundrak/SRPMS/gooddata-cl-1.1.4-2.fc14.src.rpm
Comment 7 Lubomir Rintel 2010-11-04 12:43:54 EDT
Built: http://koji.fedoraproject.org/koji/taskinfo?taskID=2576732
Comment 8 Michal Ingeli 2010-11-05 06:20:39 EDT
(In reply to comment #6)
> (In reply to comment #5)
> > - Project name and package name consistency GoodData-CL Vs. gooddata-cl
> > - Build failed for f13 [1]
> 
> F13 is too old.
> 
> and also f14 [2]. 
> 
> Fixed.

Ok. Builds fine.
 
> >   gooddata-cl.src: W: strange-permission gooddata-cli 0755L
> >   * file listed in %{_bindir}, rpmlint shouldn't be complaining
> 
> Well this is about the Source file. Fixed.

OK.

> > - missing BuildDeps reported by koji:
> > 
> > DEBUG util.py:260:  No Package Found for axis >= 1.4
> > DEBUG util.py:260:  No Package Found for javacc-maven-plugin
> > DEBUG util.py:260:  No Package Found for xpp3-minimal >= 1.1.3.8-3.4
> > DEBUG util.py:260:  No Package Found for xstream >= 1.3.1
> > DEBUG util.py:260:  No Package Found for json-lib
> > DEBUG util.py:260:  No Package Found for gdata-java > 1.39
> 
> This is on F13. That's too old.

Ok. So this package is not stated for F13 and older, EL5 and older.

- License OK.
- Packager is not using and installing maven dependency maps, so [1] is not required.
- Missing buildroot tag is OK, package is NOT for ancient releases.

* few more rpmlint warnings:

  * E: explicit-lib-dependency json-lib
  Can rpm figure out the dependency by itself?

  * W: non-conffile-in-etc /etc/gooddata-cl/log4j.configuration
  Consider adding %config

  * W: class-path-in-manifest /usr/share/java/gooddata-cl/cli-1.1.4.jar

[1] http://fedoraproject.org/wiki/Packaging/Java#maven
Comment 9 Lubomir Rintel 2010-11-05 09:49:36 EDT
(In reply to comment #8)
> * few more rpmlint warnings:
> 
>   * E: explicit-lib-dependency json-lib
>   Can rpm figure out the dependency by itself?

This is a rpmlint glitch. "lib" in the name here does not imply that the package provides a .so shared library that would be discovered by the rpm autoreq generator.

>   * W: non-conffile-in-etc /etc/gooddata-cl/log4j.configuration
>   Consider adding %config

Done.

>   * W: class-path-in-manifest /usr/share/java/gooddata-cl/cli-1.1.4.jar

Fixed

SPEC: http://v3.sk/~lkundrak/SPECS/gooddata-cl.spec
SRPM:
http://v3.sk/~lkundrak/SRPMS/gooddata-cl-1.1.4-3.fc14.src.rpm
Comment 10 Michal Ingeli 2010-11-05 10:10:50 EDT
(In reply to comment #9)
> (In reply to comment #8)
> > * few more rpmlint warnings:
> > 
> >   * E: explicit-lib-dependency json-lib
> >   Can rpm figure out the dependency by itself?
> 
> This is a rpmlint glitch. "lib" in the name here does not imply that the
> package provides a .so shared library that would be discovered by the rpm
> autoreq generator.

OK

> SPEC: http://v3.sk/~lkundrak/SPECS/gooddata-cl.spec
> SRPM:
> http://v3.sk/~lkundrak/SRPMS/gooddata-cl-1.1.4-3.fc14.src.rpm

Builds OK. Installs OK. 

APPROVED
Comment 11 Lubomir Rintel 2010-11-05 10:26:08 EDT
New Package SCM Request
=======================
Package Name: gooddata-cl
Short Description: GoodData Integration toolkit
Owners: lkundrak
Branches: f14
Comment 12 Jason Tibbitts 2010-11-05 13:17:21 EDT
Git done (by process-git-requests).
Comment 13 Lubomir Rintel 2010-11-05 14:25:21 EDT
Thanks!
Imported and built.

Note You need to log in before you can comment on or make changes to this bug.