Bug 609528
Summary: | Review Request: ghc-cairo - Haskell Cairo bindings | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jens Petersen <petersen> |
Component: | Package Review | Assignee: | Ben Boeckel <fedora> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora, fedora-package-review, haskell-devel, notting |
Target Milestone: | --- | Flags: | fedora:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | ready | ||
Fixed In Version: | ghc-cairo-0.11.1-1.fc14 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-09-02 02:19:45 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 609506 | ||
Bug Blocks: | 614024 |
Description
Jens Petersen
2010-06-30 14:01:22 UTC
Spec: http://petersen.fedorapeople.org/ghc-cairo/ghc-cairo.spec Srpm: http://petersen.fedorapeople.org/ghc-cairo/ghc-cairo-0.11.1-1.fc13.src.rpm Successful koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2410741 Taken. +:ok, !:needs attention, -:needs fixing, NA: not applicable MUST Items: [!] MUST: rpmlint output % lintmock fedora-14-x86_64-bb ghc-cairo.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum ghc-cairo.src: W: spelling-error %description -l en_US Haskell -> Gaskell, Gaitskell, Skellum ghc-cairo.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum ghc-cairo.x86_64: W: spelling-error %description -l en_US Haskell -> Gaskell, Gaitskell, Skellum ghc-cairo-devel.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum ghc-cairo-devel.x86_64: W: spelling-error %description -l en_US Haskell -> Gaskell, Gaitskell, Skellum ghc-cairo-prof.x86_64: E: devel-dependency ghc-cairo-devel ghc-cairo-prof.x86_64: W: spelling-error %description -l en_US Haskell -> Gaskell, Gaitskell, Skellum ghc-cairo-prof.x86_64: W: no-documentation ghc-cairo-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.12.3/cairo-0.11.1/libHScairo-0.11.1_p.a 4 packages and 0 specfiles checked; 1 errors, 9 warnings. All standard and waived [+] MUST: Package Naming Guidelines [+] MUST: spec file name must match base package %{name} [+] MUST: Packaging Guidelines. [+] MUST: Licensing Guidelines [+] MUST: License field in the package spec file must match actual license. [+] MUST: include license files in %doc if available in source [+] MUST: The spec file must be written in American English and be legible. [+] MUST: source md5sum matches upstream release 01056ece6c8872d30cbc0f11eef98e40 cairo-0.11.1.tar.gz [+] MUST: must successfully compile and build into binary rpms on one main arch Requires ghc-glib which isn't in Fedora yet. Builds locally. [+] MUST: if necessary use ExcludeArch for other archs [+] MUST: All build dependencies must be listed in BuildRequires [NA] MUST: use %find_lang macro for .po translations [NA] MUST: packages which store shared library files in the dynamic linker's default paths, must call ldconfig in %post and %postun. [NA] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review [+] MUST: A package must own all directories that it creates. [+] MUST: A package must not contain any duplicate files in the %files listing. [+] MUST: Permissions on files must be set properly. Every %files section must include a %defattr(...) line. [+] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: Each package must consistently use macros, as described in the macros section of Packaging Guidelines. [+] MUST: The package must contain code, or permissable content. [+] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [+] MUST: Header files must be in a -devel package. [NA] MUST: Static libraries must be in a -static package. [NA] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [+] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency [+] MUST: Packages must NOT contain any .la libtool archives, these should be removed in the spec. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [+] MUST: All filenames in rpm packages must be valid UTF-8. SHOULD Items: [+] SHOULD: If scriptlets are used, those scriptlets must be sane. [+] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. Yay cabal2spec. Looks good. APPROVED. Thanks, Ben :) New Package SCM Request ======================= Package Name: ghc-cairo Short Description: Haskell Cairo bindings Owners: petersen Branches: f14 InitialCC: haskell-sig Git done (by process-git-requests). Built for f15 and f14. ghc-cairo-0.11.1-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/ghc-cairo-0.11.1-1.fc14 ghc-cairo-0.11.1-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: ghc-cairo New Branches: el6 Owners: petersen InitialCC: haskell-sig Sorry I need f13 too: Package Change Request ====================== Package Name: ghc-cairo New Branches: f13 el6 Owners: petersen InitialCC: haskell-sig Git done (by process-git-requests). |