Bug 614024 (ghc-pango) - Review Request: ghc-pango - Haskell pango binding
Summary: Review Request: ghc-pango - Haskell pango binding
Alias: ghc-pango
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Ben Boeckel
QA Contact: Fedora Extras Quality Assurance
Depends On: 609518 609528
Blocks: ghc-gtk
TreeView+ depends on / blocked
Reported: 2010-07-13 14:21 UTC by Jens Petersen
Modified: 2010-11-11 15:52 UTC (History)
4 users (show)

Fixed In Version: ghc-pango-0.11.2-1.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2010-09-23 12:30:44 UTC
mathstuf: fedora-review+
tibbs: fedora-cvs+

Attachments (Terms of Use)

Description Jens Petersen 2010-07-13 14:21:02 UTC
Spec URL: http://petersen.fedorapeople.org/ghc-pango/ghc-pango.spec
SRPM URL: http://petersen.fedorapeople.org/ghc-pango/ghc-pango-0.11.0-1.fc12.src.rpm
Haskell binding to Pango from the gtk2hs project.

Comment 1 Jens Petersen 2010-08-19 02:03:55 UTC
Will update to pango-0.11.2 once glib review is done.

Comment 3 Ben Boeckel 2010-09-01 23:27:33 UTC

 +:ok, !:needs attention, -:needs fixing,  NA: not applicable

MUST Items:
[+] MUST: rpmlint output

% lintmock fedora-14-x86_64-bb
ghc-pango.src: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
ghc-pango.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
ghc-pango-devel.x86_64: W: spelling-error Summary(en_US) Haskell -> Gaskell, Gaitskell, Skellum
ghc-pango-prof.x86_64: E: devel-dependency ghc-pango-devel
ghc-pango-prof.x86_64: W: no-documentation
ghc-pango-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.12.3/pango-0.11.0/libHSpango-0.11.0_p.a
4 packages and 0 specfiles checked; 1 errors, 5 warnings.

All standard and waived

[+] MUST: Package Naming Guidelines
[+] MUST: spec file name must match base package %{name}
[+] MUST: Packaging Guidelines.
[+] MUST: Licensing Guidelines
[+] MUST: License field in the package spec file must match actual license.
[+] MUST: include license files in %doc if available in source
[+] MUST: The spec file must be written in American English and be legible.
[+] MUST: source md5sum matches upstream release

ca461174a78af94b361ad687b651d015  ../SOURCES/pango-0.11.0.tar.gz

[+] MUST: must successfully compile and build into binary rpms on one main arch

Requires newly reviewed packages. Builds for F14 x86_64 here.

[+] MUST: if necessary use ExcludeArch for other archs
[+] MUST: All build dependencies must be listed in BuildRequires
[NA] MUST: use %find_lang macro for .po translations
[NA] MUST: packages which store shared library files in the dynamic linker's
default paths, must call ldconfig in %post and %postun.
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review
[+] MUST: A package must own all directories that it creates.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Every %files section must
include a %defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissable content.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[NA] MUST: Static libraries must be in a -static package.
[NA] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[+] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[+] MUST: Packages must not own files or directories already owned by other
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[+] SHOULD: If scriptlets are used, those scriptlets must be sane.
[+] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.


Comment 4 Jens Petersen 2010-09-02 02:55:02 UTC

New Package SCM Request
Package Name: ghc-pango
Short Description: Haskell pango binding
Owners: petersen
Branches: f14
InitialCC: haskell-sig

Comment 5 Kevin Fenzi 2010-09-02 21:32:35 UTC
Git done (by process-git-requests).

Comment 6 Jens Petersen 2010-09-03 03:29:16 UTC
Build failure http://koji.fedoraproject.org/koji/taskinfo?taskID=2444251

Comment 7 Jens Petersen 2010-09-03 06:25:59 UTC
Finally succeeded (on x86-04) after many .as link failures, like this:


Comment 8 Jens Petersen 2010-09-03 06:29:36 UTC
For reference from cabal build -v3 output:

*** Checking old interface for pango-0.11.2:Graphics.Rendering.Pango.Types:
[ 1 of 14] Compiling Graphics.Rendering.Pango.Types ( dist/build/Graphics/Rendering/Pango/Types.hs, dist/build/Graphics/Rendering/Pango/Types.dyn_o )
*** CorePrep:
    Result size = 954
*** Stg2Stg:
*** CodeGen:
*** CodeOutput:
*** Assembler:
/usr/bin/gcc -Idist/build/Graphics/Rendering/Pango -Idist/build -Idist/build/autogen -Idist/build -Idist/build/autogen -Idist/build -I. -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -c /tmp/ghc27622_0/ghc27622_0.s -o dist/build/Graphics/Rendering/Pango/Types.dyn_o
/tmp/ghc27622_0/ghc27622_0.s: Assembler messages:
     Error: junk `el' after expression
     Error: 8-byte relocation cannot be applied to 4-byte field

Comment 9 Fedora Update System 2010-09-03 07:00:58 UTC
ghc-pango-0.11.2-1.fc14 has been submitted as an update for Fedora 14.

Comment 10 Fedora Update System 2010-09-03 16:43:22 UTC
ghc-pango-0.11.2-1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update ghc-pango'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/ghc-pango-0.11.2-1.fc14

Comment 11 Fedora Update System 2010-09-23 12:30:39 UTC
ghc-pango-0.11.2-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 12 Jens Petersen 2010-11-10 07:47:55 UTC
Package Change Request
Package Name: ghc-pango
New Branches: f13 el6
Owners: petersen
InitialCC: haskell-sig

Comment 13 Jason Tibbitts 2010-11-11 15:52:57 UTC
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.