Bug 611054
| Summary: | Review Request: python-carrot - AMQP Messaging Framework for Python | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> | ||||
| Component: | Package Review | Assignee: | David Nalley <david> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | andrew.elwell, bdpepple, bloch, david, fedora-package-review, metherid, notting | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2011-01-29 01:41:38 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 611048 | ||||||
| Bug Blocks: | 201449 | ||||||
| Attachments: |
|
||||||
|
Description
Fabian Affolter
2010-07-03 10:55:42 UTC
* Mon Nov 01 2010 Fabian Affolter <fabian> - 0.10.7-1 - Updated to new upstream release 0.10.7 Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-carrot.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-carrot-0.10.7-1.fc14.src.rpm Created attachment 469111 [details]
informal review
Hi, As I'm hoping to become a packager I've done an informal review of this package. Full comments on the ReviewGuidelines are attached, but a couple of things I'd like to highlight are: * no CFLAGS in the %build section -- see http://fedoraproject.org/wiki/PackagingGuidelines#Compiler_flags CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build * your dependency on 'Requires: python-json' means I couldn't install it on a stock F14 laptop -- which json implementation do you need? * rpmlint threw warnings about no buildroot. BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) is the default that comes with rpmdev-newspec * finally upstream says on https://github.com/ask/carrot/#readme that "Carrot is discontinued in favor of the new Kombu framework. Kombu is ready, start to use it now! Kombu comes with a Carrot compatible API, so it's easy to port your software. Carrot will not be actively maintained, only critical bugs will be fixed." -- you may want to mention this in the description... Andrew, please don't attach package reviews; just paste them in. Otherwise it is difficult for us to see them. OK, Will do. Wasn't sure of the ettiquette of pasting large chunks of text in. Fabian: Andrew's comments appear to be correct wrt to python-json - python2.6 (and 3000) contains a json module, so that BR should probably be stripped (or conditionalized if you plan on building this for the EL < 6) If you do plan on building for EL < 6 you need Buildroot specified. Andrew's informal review looks pretty good I'll ACK Andrew's review as well. Fabian, are you still interested in submitting this to Fedora? If not, please reply so we can have someone else work on this, since python-carrot is a dep for openstack-nova. Thanks. This hasn't been touched since December 10th - despite four additional people providing comments and bpepple has indicated that he's interested in picking it up. http://fedoraproject.org/wiki/PackageMaintainers/Policy#Submitter_not_responding *** This bug has been marked as a duplicate of bug 673637 *** |