Bug 611054 - Review Request: python-carrot - AMQP Messaging Framework for Python
Summary: Review Request: python-carrot - AMQP Messaging Framework for Python
Status: CLOSED DUPLICATE of bug 673637
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: David Nalley
QA Contact: Fedora Extras Quality Assurance
Depends On: python-amqplib
TreeView+ depends on / blocked
Reported: 2010-07-03 10:55 UTC by Fabian Affolter
Modified: 2012-06-29 22:32 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2011-01-29 01:41:38 UTC
Type: ---

Attachments (Terms of Use)
informal review (10.15 KB, text/plain)
2010-12-16 10:45 UTC, Andrew Elwell
no flags Details

Description Fabian Affolter 2010-07-03 10:55:42 UTC
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-carrot.spec
SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-carrot-0.10.5-1.fc13.src.rpm

Project URL: http://pypi.python.org/pypi/carrot

carrot is an AMQP messaging queue framework. AMQP is the Advanced
Message Queuing Protocol, an open standard protocol for message
orientation, queuing, routing, reliability and security.

The aim of carrot is to make messaging in Python as easy as possible
by providing a high-level interface for producing and consuming
messages. At the same time it is a goal to re-use what is already
available as much as possible.

Koji scratch build:

rpmlint output:
[fab@laptop011 SRPMS]$ rpmlint python-carrot-0.10.5-1.fc13.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@laptop011 noarch]$ rpmlint python-carrot-0.10.5-1.fc13.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Fabian Affolter 2010-11-10 21:41:20 UTC
* Mon Nov 01 2010 Fabian Affolter <fabian> - 0.10.7-1
- Updated to new upstream release 0.10.7

Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-carrot.spec

Comment 2 Andrew Elwell 2010-12-16 10:45:44 UTC
Created attachment 469111 [details]
informal review

Comment 3 Andrew Elwell 2010-12-16 10:46:12 UTC
Hi, As I'm hoping to become a packager I've done an informal review of this package. 

Full comments on the ReviewGuidelines are attached, but a couple of things I'd like to highlight are:

* no CFLAGS in the %build section -- see 
CFLAGS="$RPM_OPT_FLAGS" %{__python} setup.py build

* your dependency on 'Requires:       python-json' means I couldn't install it on a stock F14 laptop -- which json implementation do you need?

* rpmlint threw warnings about no buildroot. 
BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
is the default that comes with rpmdev-newspec

* finally upstream says on https://github.com/ask/carrot/#readme
that "Carrot is discontinued in favor of the new Kombu framework.

Kombu is ready, start to use it now!
Kombu comes with a Carrot compatible API, so it's easy to port your software.
Carrot will not be actively maintained, only critical bugs will be fixed."

-- you may want to mention this in the description...

Comment 4 Jason Tibbitts 2010-12-16 17:52:12 UTC
Andrew, please don't attach package reviews; just paste them in.  Otherwise it is difficult for us to see them.

Comment 5 Andrew Elwell 2010-12-16 18:00:39 UTC
OK, Will do. Wasn't sure of the ettiquette of pasting large chunks of text in.

Comment 6 David Nalley 2011-01-09 17:48:35 UTC

Andrew's comments appear to be correct wrt to python-json - python2.6 (and 3000) contains a json module, so that BR should probably be stripped (or conditionalized if you plan on building this for the EL < 6) 

If you do plan on building for EL < 6 you need Buildroot specified. 

Andrew's informal review looks pretty good

Comment 7 Jason Tibbitts 2011-01-21 23:19:15 UTC
I'll ACK Andrew's review as well.

Comment 8 Brian Pepple 2011-01-28 21:49:55 UTC
Fabian, are you still interested in submitting this to Fedora? If not, please reply so we can have someone else work on this, since python-carrot is a dep for openstack-nova. Thanks.

Comment 9 David Nalley 2011-01-29 01:41:38 UTC
This hasn't been touched since December 10th - despite four additional people providing comments and bpepple has indicated that he's interested in picking it up. 


Comment 10 Rahul Sundaram 2011-05-11 06:43:26 UTC

*** This bug has been marked as a duplicate of bug 673637 ***

Note You need to log in before you can comment on or make changes to this bug.