Bug 611436

Summary: Make bundle creation error messages more friendly
Product: [Other] RHQ Project Reporter: Rajan Timaniya <rtimaniy>
Component: ProvisioningAssignee: Jay Shaughnessy <jshaughn>
Status: CLOSED CURRENTRELEASE QA Contact: Sunil Kondkar <skondkar>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.0.0CC: cwelton, jshaughn, mazz, skondkar
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: 3.0.0.GA 4.0.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-12-14 14:40:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 565628, 577210    
Attachments:
Description Flags
screenshot none

Description Rajan Timaniya 2010-07-05 09:19:47 UTC
Created attachment 429494 [details]
screenshot

Description of problem:
Bundle creation via URL_invalid URL –  didn't display error message and failure reason.

Version-Release number of selected component (if applicable):
JON 2.4 GA_QA (tag-jon-release build# 49)
build number: 10775:e086474

How reproducible:
Always

Steps to Reproduce:
1. Go to Administration->Content->Bundles
2. Click on button 'New'.
3. Select the radio button 'URL'.
4. Enter an invalid URL type in text box
   (Ex: Enter plain text or special characters in text box)
5. Click on Next button.
  
Actual results:
Bundle creation via URL_invalid URL –  didn't display error message and failure reason.

Expected results:
UI should display proper error message and failure reason in the wizard box.

Additional info:
Please refer attached screenshot.

Comment 1 Rajan Timaniya 2010-07-05 09:24:16 UTC
Same issue find when user select the radio button 'URL' and without provide
any url click on 'Next' button.

Expected results:
UI should display proper error message and failure reason in the wizard box.

Comment 2 Sunil Kondkar 2010-07-05 11:31:50 UTC
Updating the bug for the same observation: When user uploads an empty or invalid recipe, or when user selects recipe option and proceeds without entering recipe details. The error message displayed is in the 'Messages' dropdown. 

Expected result: The error message and failure reason should be displayed in the wizard box.

Comment 3 Jay Shaughnessy 2010-07-07 19:52:20 UTC
fix commit: 91c9d1fb7849b9966f60a2cdeb8bca1903e3389c

There is a new messaging and is displayed within the wizard.

Comment 4 Sunil Kondkar 2010-07-09 09:04:00 UTC
Tested on latest jon 2.4.0.GA_QA build#53

Below are the observations:

1) When user enters invalid URL type(asdasd) in text box and click 'Next'- The bundle creation wizard displays: 

java.net.MalformedURLException:no protocol: asdasd

2) When user select the radio button 'URL' and clicks on 'Next' button without providing any url-The bundle creation wizard displays: 
 
java.net.MalformedURLException:null

3) When user uploads an empty or invalid recipe-The bundle creation wizard displays: 

javax.ejb.EJBException:java.lang.IllegalArgumentException: Invalid recipe not recognized by any deployed server bundle plugin. -> java.lang.IllegalArgumentException:Invalid recipe not recognized by any deployed server bundle plugin.

4) when user selects recipe option and proceeds without entering recipe details-The bundle creation wizard displays: 

javax.ejb.EJBException:java.lang.IllegalArgumentException: recipe == null -> java.lang.IllegalArgumentException:recipe == null


In all above scenarios, the bundle wizard displays the failure reason as expected. 

However it is not displaying error messages like "Please select a valid URL"/"Please enter the URL"/"Please select a valid recipe file to upload" etc.

Comment 5 Corey Welton 2010-07-21 01:21:35 UTC
*** Bug 616262 has been marked as a duplicate of this bug. ***

Comment 6 Corey Welton 2010-09-28 12:51:40 UTC
Triaged 24-Sept

Comment 7 Jay Shaughnessy 2010-12-14 14:40:15 UTC
The messaging could still improve (like everything :) but until we get more requests for more work here I think we're good.  If necessary we can open a new BZ in the future.