Bug 612943
| Summary: | Review Request: spice-protocol - Spice protocol header files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gerd Hoffmann <kraxel> |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mclasen, notting |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-07-13 12:38:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Gerd Hoffmann
2010-07-09 11:17:12 UTC
Builds fine in mock. $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/stats.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/qxl_dev.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/vdi_dev.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/barrier.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/ipc_ring.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/macros.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/spice-protocol.pc spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/enums.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/vd_agent.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/start-packed.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/end-packed.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/protocol.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/error_codes.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/types.h 2 packages and 0 specfiles checked; 0 errors, 14 warnings. The license field in the spec file looks wrong. package name: ok spec file name: ok packaging guidelines: ok, but if the package is only meant for F13+, then some cleanups are possible: - drop BuildRoot - drop initial rm -rf in %install - drop %clean section license: ok license file: ok license field: should be BSD, not GPLv2+ spec language: ok spec readable: yes upstream sources: ok buildable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok directory ownership: ok duplicate files: ok file permissions: ok (pedants prefer the 4-argument form of %defattr) macro use: ok permissible content: ok large docs: ok %doc content: ok headers: ok (the wording of the guidelines is a bit unfortunate here...) static libs: ok shared libs: ok libtool archives: ok devel deps: ok gui apps: ok file ownership: ok utf8 filenames: ok Summary: - fix the license - apply minor cleanups at your discretion Updated package + specfile are uploaded to http://kraxel.fedorapeople.org/review/spice-protocol/ Looks good now. Approved New Package CVS Request ======================= Package Name: spice-protocol Short Description: Spice protocol header files Owners: kraxel alexl Branches: InitialCC: CVS done (by process-cvs-requests.py). rawhide builds are done. |