Spec URL: http://kraxel.fedorapeople.org/review/spice-protocol/spice-protocol.spec SRPM URL: http://kraxel.fedorapeople.org/review/spice-protocol/spice-protocol-0.5.2-1.fc14.src.rpm Description: Header files describing the spice protocol and the para-virtual graphics card QXL.
Builds fine in mock. $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/stats.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/qxl_dev.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/vdi_dev.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/barrier.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/ipc_ring.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/macros.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/share/pkgconfig/spice-protocol.pc spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/enums.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/vd_agent.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/start-packed.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/end-packed.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/protocol.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/error_codes.h spice-protocol.noarch: W: devel-file-in-non-devel-package /usr/include/spice-1/spice/types.h 2 packages and 0 specfiles checked; 0 errors, 14 warnings.
The license field in the spec file looks wrong.
package name: ok spec file name: ok packaging guidelines: ok, but if the package is only meant for F13+, then some cleanups are possible: - drop BuildRoot - drop initial rm -rf in %install - drop %clean section license: ok license file: ok license field: should be BSD, not GPLv2+ spec language: ok spec readable: yes upstream sources: ok buildable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: ok directory ownership: ok duplicate files: ok file permissions: ok (pedants prefer the 4-argument form of %defattr) macro use: ok permissible content: ok large docs: ok %doc content: ok headers: ok (the wording of the guidelines is a bit unfortunate here...) static libs: ok shared libs: ok libtool archives: ok devel deps: ok gui apps: ok file ownership: ok utf8 filenames: ok Summary: - fix the license - apply minor cleanups at your discretion
Updated package + specfile are uploaded to http://kraxel.fedorapeople.org/review/spice-protocol/
Looks good now. Approved
New Package CVS Request ======================= Package Name: spice-protocol Short Description: Spice protocol header files Owners: kraxel alexl Branches: InitialCC:
CVS done (by process-cvs-requests.py).
rawhide builds are done.