Bug 614075
| Summary: | Review Request: libqttracker - Qt Bindings for the Tracker media indexing infrastructure | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chen Lei <supercyper1> |
| Component: | Package Review | Assignee: | Jaroslav Reznik <jreznik> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, jreznik, notting, rdieter |
| Target Milestone: | --- | Flags: | jreznik:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-09-09 02:08:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Chen Lei
2010-07-13 16:04:27 UTC
New upstream release: SPEC:http://dl.dropbox.com/u/1338197/1/libqttracker.spec SRPM:http://dl.dropbox.com/u/1338197/1/libqttracker-6.9.8-1.fc13.src.rpm New upstream release: http://dl.dropbox.com/u/1338197/1/libqttracker.spec http://dl.dropbox.com/u/1338197/1/libqttracker-6.10.0-1.fc13.src.rpm New upstream release: http://dl.dropbox.com/u/1338197/1/libqttracker.spec http://dl.dropbox.com/u/1338197/1/libqttracker-6.11.0-1.fc13.src.rpm Name and summary: ok Group: ok License: ok URL: ok Sources: NOT ok! looks like there are indeed no sources released but current version can't be found in daily maemo repository... upstream should be asked to make a proper download location or it should point at least to correct repository Description: ok Contains -devel subpackage: ok I have to leave now, please fix sources issues. Other question is version - from changelog it looks like it's pre-release version - so spec file should reflect it in version and release tag. Fix sources issue: http://dl.dropbox.com/u/1338197/1/libqttracker.spec http://dl.dropbox.com/u/1338197/1/libqttracker-6.11.0-2.fc13.src.rpm The meego packages are a special case, they don't release any tarballs publicly, so git tag 1pre6.11.0 is equal to formal release 6.11.0. Thanks. Package builds: ok, on x86_64. md5sum: ok RPMLint output: NOT ok libqttracker.src: W: no-cleaning-of-buildroot %clean libqttracker.src: W: no-buildroot-tag libqttracker.src: W: no-%clean-section (In reply to comment #6) > RPMLint output: NOT ok > libqttracker.src: W: no-cleaning-of-buildroot %clean > libqttracker.src: W: no-buildroot-tag > libqttracker.src: W: no-%clean-section Buldroot tag and %clean are no longer needed for F13 and above. http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag (In reply to comment #7) > (In reply to comment #6) > > RPMLint output: NOT ok > > libqttracker.src: W: no-cleaning-of-buildroot %clean > > libqttracker.src: W: no-buildroot-tag > > libqttracker.src: W: no-%clean-section > > Buldroot tag and %clean are no longer needed for F13 and above. > http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag I know but it's still the MUST for F12 - so you don't expect libqttracker to be pushed to F12? Packaging meego related packages for F13 and below is meanless because some core components require qt >=4.7. Ok, makes sense - we are not going to update Qt 4.7 for F12 as it's probably already too late. APPROVED Thanks for the review, Jaroslav. New Package CVS Request ======================= Package Name: libqttracker Short Description: Qt Bindings for the Tracker media indexing infrastructure Owners: supercyper Branches: F-14 InitialCC: Git done (by process-git-requests). |