Bug 614075 - Review Request: libqttracker - Qt Bindings for the Tracker media indexing infrastructure
Summary: Review Request: libqttracker - Qt Bindings for the Tracker media indexing inf...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Jaroslav Reznik
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-07-13 16:04 UTC by Chen Lei
Modified: 2010-09-09 02:08 UTC (History)
4 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2010-09-09 02:08:09 UTC
Type: ---
Embargoed:
jreznik: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Chen Lei 2010-07-13 16:04:27 UTC
Description:
LibQtTracker is a Qt convenience library for accessing tracker.

SPEC:http://dl.dropbox.com/u/1338197/1/libqttracker.spec
SRPM:http://dl.dropbox.com/u/1338197/1/libqttracker-6.9.2-1.fc13.src.rpm

Comment 4 Jaroslav Reznik 2010-09-06 15:35:46 UTC
Name and summary: ok
Group: ok
License: ok
URL: ok

Sources: NOT ok! looks like there are indeed no sources released but current version can't be found in daily maemo repository... upstream should be asked to make a proper download location or it should point at least to correct repository

Description: ok
Contains -devel subpackage: ok

I have to leave now, please fix sources issues. Other question is version - from changelog it looks like it's pre-release version - so spec file should reflect it in version and release tag.

Comment 5 Chen Lei 2010-09-07 02:16:34 UTC
Fix sources issue:

http://dl.dropbox.com/u/1338197/1/libqttracker.spec
http://dl.dropbox.com/u/1338197/1/libqttracker-6.11.0-2.fc13.src.rpm


The meego packages are a special case, they don't release any tarballs publicly, so git tag 1pre6.11.0 is equal to formal release 6.11.0.

Comment 6 Jaroslav Reznik 2010-09-07 10:54:01 UTC
Thanks.

Package builds: ok, on x86_64.
md5sum: ok

RPMLint output: NOT ok
libqttracker.src: W: no-cleaning-of-buildroot %clean
libqttracker.src: W: no-buildroot-tag
libqttracker.src: W: no-%clean-section

Comment 7 Chen Lei 2010-09-07 12:08:50 UTC
(In reply to comment #6)
> RPMLint output: NOT ok
> libqttracker.src: W: no-cleaning-of-buildroot %clean
> libqttracker.src: W: no-buildroot-tag
> libqttracker.src: W: no-%clean-section

Buldroot tag and %clean are no longer needed for F13 and above.
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

Comment 8 Jaroslav Reznik 2010-09-07 13:54:12 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > RPMLint output: NOT ok
> > libqttracker.src: W: no-cleaning-of-buildroot %clean
> > libqttracker.src: W: no-buildroot-tag
> > libqttracker.src: W: no-%clean-section
> 
> Buldroot tag and %clean are no longer needed for F13 and above.
> http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

I know but it's still the MUST for F12 - so you don't expect libqttracker to be pushed to F12?

Comment 9 Chen Lei 2010-09-07 14:05:06 UTC
Packaging meego related packages for F13 and below is meanless because some core components require qt >=4.7.

Comment 10 Jaroslav Reznik 2010-09-07 14:46:40 UTC
Ok, makes sense - we are not going to update Qt 4.7 for F12 as it's probably already too late.

APPROVED

Comment 11 Chen Lei 2010-09-07 16:50:17 UTC
Thanks for the review, Jaroslav.

New Package CVS Request
=======================
Package Name: libqttracker
Short Description: Qt Bindings for the Tracker media indexing infrastructure
Owners: supercyper
Branches: F-14
InitialCC:

Comment 12 Kevin Fenzi 2010-09-08 17:56:06 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.