Bug 614329
| Summary: | Review Request: emacs-common-w3m - W3m interface for Emacsen | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Akira TAGOH <tagoh> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, i18n-bugs, michel, notting, panemade, petersen |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-08-02 04:45:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 657745, 657746 | ||
| Bug Blocks: | 595213 | ||
|
Description
Akira TAGOH
2010-07-14 07:02:09 UTC
Suggestions: 1) missing obsoletes and provides for renamed package See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Renaming.2Freplacing_existing_packages 2) If package is needed only for F-13 and above then a) %clean not needed b) cleaning of buildroot at start of %install also not needed 3) Please provide steps in comments on how can one generate the source tarball. Thanks for pointing them out. updated: Spec URL: http://tagoh.fedorapeople.org/reviews/emacs-common-w3m/emacs-common-w3m.spec SRPM URL: http://tagoh.fedorapeople.org/reviews/emacs-common-w3m/emacs-common-w3m-1.4.398-0.2.20100714cvs.fc14.src.rpm Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2350728 + rpmlint output for SRPM and for RPM. emacs-common-w3m.src: W: no-cleaning-of-buildroot %clean emacs-common-w3m.src: W: no-buildroot-tag emacs-common-w3m.src: W: no-%clean-section emacs-common-w3m.src: W: invalid-url Source0: emacs-w3m-1.4.398.tar.gz emacs-w3m.noarch: W: spelling-error Summary(en_US) elisp -> lisp, e lisp, Elise emacs-w3m.noarch: W: spelling-error %description -l en_US elisp -> lisp, e lisp, Elise emacs-w3m.noarch: W: no-documentation emacs-w3m-el.noarch: W: spelling-error Summary(en_US) Elisp -> Elis, Lisp, Elise emacs-w3m-el.noarch: W: spelling-error %description -l en_US elisp -> lisp, e lisp, Elise emacs-w3m-el.noarch: W: obsolete-not-provided w3m-el emacs-w3m-el.noarch: W: no-documentation xemacs-w3m.noarch: W: spelling-error Summary(en_US) elisp -> lisp, e lisp, Elise xemacs-w3m.noarch: W: spelling-error %description -l en_US elisp -> lisp, e lisp, Elise xemacs-w3m.noarch: W: no-documentation xemacs-w3m-el.noarch: W: spelling-error Summary(en_US) Elisp -> Elis, Lisp, Elise xemacs-w3m-el.noarch: W: spelling-error %description -l en_US elisp -> lisp, e lisp, Elise xemacs-w3m-el.noarch: W: obsolete-not-provided w3m-el-xemacs xemacs-w3m-el.noarch: W: no-documentation => These messages can be ignored emacs-w3m.noarch: W: name-repeated-in-summary C Emacs-w3m ==>This is not a blocker though as its because of following the spec template for emacs addons. + source files match upstream url when packaged according to given steps. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present which is not needed now. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + following emacs packaging guidelines + Not a GUI application Suggestions: 1) use install commands with "install -p" to preserve timestamps 2)wherever possible use https://fedoraproject.org/wiki/Packaging/Guidelines#Parallel_make Please do the above changes before you import this in cvs. APPROVED. Thanks for reviews. the above suggestions has been applied with: Spec URL: http://tagoh.fedorapeople.org/reviews/emacs-common-w3m/emacs-common-w3m.spec SRPM URL: http://tagoh.fedorapeople.org/reviews/emacs-common-w3m/emacs-common-w3m-1.4.398-0.3.20100714cvs.fc14.src.rpm New Package CVS Request ======================= Package Name: emacs-common-w3m Short Description: W3m interface for Emacsen Owners: tagoh Branches: devel F-13 F-12 InitialCC: *** Bug 595213 has been marked as a duplicate of this bug. *** GIT done (by process-cvs-requests.py). with f14 branch added. Thanks. the package has been built in koji. Package Change Request ====================== Package Name: emacs-common-w3m New Branches: el6 Owners: salimma InitialCC: Needed for full functionality of pure's emacs mode. We need an ack from the current Fedora maintainer. Please go ahead. Git done (by process-git-requests). |