Bug 614692
| Summary: | Review Request:qtiocompressor - QIODevice that compresses data streams | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Orcan Ogetbil <oget.fedora> |
| Component: | Package Review | Assignee: | Mattias Ellert <mattias.ellert> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | mattias.ellert:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | qtiocompressor-2.3.1-1.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-08-05 23:32:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 583327 | ||
|
Description
Orcan Ogetbil
2010-07-15 01:49:00 UTC
Fedora Review qtiocompressor 2010-07-15
rpmlint output:
$ rpmlint qtiocompressor-2.3.1-1.fc12.src.rpm \
qtiocompressor-2.3.1-1.fc12.x86_64.rpm \
qtiocompressor-devel-2.3.1-1.fc12.x86_64.rpm \
qtiocompressor-debuginfo-2.3.1-1.fc12.x86_64.rpm
qtiocompressor.src:46: W: configure-without-libdir-spec
4 packages and 0 specfiles checked; 0 errors, 1 warnings.
OK - the build get the compiler flags from qt-devel
+ Package is named according to guidelines
+ Specfile is named after package
+ The Package license tag (GPLv3 or LGPLv2 with exceptions) is a
Fedora approved license
+ The Package license tag matches the license statements in the sources
+ The license files are included in the package as %doc:
LICENSE.GPL3, LICENSE.LGPL, LGPL_EXCEPTION.txt
+ The specfile is written in legible English
+ Source matches upstream:
md5sum srpm/qtiocompressor-2.3_1-opensource.tar.gz \
qtiocompressor-2.3_1-opensource.tar.gz
73bbde56cf705602b4f180b379756a40 srpm/qtiocompressor-2.3_1-opensource.tar.gz
73bbde56cf705602b4f180b379756a40 qtiocompressor-2.3_1-opensource.tar.gz
+ Koji scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=2321485
+ BuildRequires are sane
+ No locales
+ Package calls ldconfig appropriately
+ No bundled libraries
+ Package owns directories it creates
+ No duplicate files
+ Permissions are sane and %files has %defattr
+ Specfile uses macros consistently
+ %doc is not runtime essential
+ Headers in -devel
+ No static libraries
+ .so link in -devel
+ -devel requires main with fully qualified version
+ No libtool archives
+ A repoquery reveals that the /usr/include/QtSolutions directory is
already owned by qtlockedfile-devel - but I guess this falls into
the category "Multiple packages own files in a common directory but
none of them needs to require the others". If there will be many
packages putting files there it might be an idea to put this
directory in qt-devel.
+ Installed files have valid UTF-8 filenames
Package approved.
Thanks for the fast review. I appreciate it. Is there any review I can do for you? New Package CVS Request ======================= Package Name: qtiocompressor Short Description: QIODevice that compresses data streams Owners: oget Branches: F-12 F-13 InitialCC: CVS done (by process-cvs-requests.py). qtiocompressor-2.3.1-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/qtiocompressor-2.3.1-1.fc13 qtiocompressor-2.3.1-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/qtiocompressor-2.3.1-1.fc12 qtiocompressor-2.3.1-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. qtiocompressor-2.3.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |