Spec URL: http://oget.fedorapeople.org/review/qtiocompressor.spec SRPM URL: http://oget.fedorapeople.org/review/qtiocompressor-2.3.1-1.fc13.src.rpm Description: The class works on top of a QIODevice subclass, compressing data before it is written and decompressing it when it is read. Since QtIOCompressor works on streams, it does not have to see the entire data set before compressing or decompressing it. This can reduce the memory requirements when working on large data sets. The specfile is just stolen and converted from qtsingleapplication: bug 581220. rpmlints: qtiocompressor.src:46: W: configure-without-libdir-spec As said in the specfile, this doesn't use the usual GNU configure: koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2321012
Fedora Review qtiocompressor 2010-07-15 rpmlint output: $ rpmlint qtiocompressor-2.3.1-1.fc12.src.rpm \ qtiocompressor-2.3.1-1.fc12.x86_64.rpm \ qtiocompressor-devel-2.3.1-1.fc12.x86_64.rpm \ qtiocompressor-debuginfo-2.3.1-1.fc12.x86_64.rpm qtiocompressor.src:46: W: configure-without-libdir-spec 4 packages and 0 specfiles checked; 0 errors, 1 warnings. OK - the build get the compiler flags from qt-devel + Package is named according to guidelines + Specfile is named after package + The Package license tag (GPLv3 or LGPLv2 with exceptions) is a Fedora approved license + The Package license tag matches the license statements in the sources + The license files are included in the package as %doc: LICENSE.GPL3, LICENSE.LGPL, LGPL_EXCEPTION.txt + The specfile is written in legible English + Source matches upstream: md5sum srpm/qtiocompressor-2.3_1-opensource.tar.gz \ qtiocompressor-2.3_1-opensource.tar.gz 73bbde56cf705602b4f180b379756a40 srpm/qtiocompressor-2.3_1-opensource.tar.gz 73bbde56cf705602b4f180b379756a40 qtiocompressor-2.3_1-opensource.tar.gz + Koji scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=2321485 + BuildRequires are sane + No locales + Package calls ldconfig appropriately + No bundled libraries + Package owns directories it creates + No duplicate files + Permissions are sane and %files has %defattr + Specfile uses macros consistently + %doc is not runtime essential + Headers in -devel + No static libraries + .so link in -devel + -devel requires main with fully qualified version + No libtool archives + A repoquery reveals that the /usr/include/QtSolutions directory is already owned by qtlockedfile-devel - but I guess this falls into the category "Multiple packages own files in a common directory but none of them needs to require the others". If there will be many packages putting files there it might be an idea to put this directory in qt-devel. + Installed files have valid UTF-8 filenames Package approved.
Thanks for the fast review. I appreciate it. Is there any review I can do for you? New Package CVS Request ======================= Package Name: qtiocompressor Short Description: QIODevice that compresses data streams Owners: oget Branches: F-12 F-13 InitialCC:
CVS done (by process-cvs-requests.py).
qtiocompressor-2.3.1-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/qtiocompressor-2.3.1-1.fc13
qtiocompressor-2.3.1-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/qtiocompressor-2.3.1-1.fc12
qtiocompressor-2.3.1-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report.
qtiocompressor-2.3.1-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.