Bug 618042

Summary: Review Request: kwebkitpart - A KPart based on QtWebKit
Product: [Fedora] Fedora Reporter: nucleo <alekcejk>
Component: Package ReviewAssignee: Rex Dieter <rdieter>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, rdieter
Target Milestone: ---Flags: rdieter: fedora-review+
petersen: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: kwebkitpart-0.9.6-1.fc12 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-09-23 04:55:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description nucleo 2010-07-25 19:55:25 UTC
Spec URL:
http://nucleo.fedorapeople.org/pkg-reviews/kwebkitpart/kwebkitpart.spec

SRPM URL:
http://nucleo.fedorapeople.org/pkg-reviews/kwebkitpart/kwebkitpart-0.9.6-1.fc13.src.rpm

Description:
KWebKitPart is a web browser component for KDE (KPart)
based on (Qt)WebKit. You can use it for example for
browsing the web in Konqueror.


All kwebkitpart code have LGPLv2+ license.
kdelauncher/main.cpp have BSD license but it not installed. It is needed only for development purpose.

$ rpmlint kwebkitpart-0.9.6-1.fc13.i686.rpm kwebkitpart-devel-0.9.6-1.fc13.i686.rpm kwebkitpart-debuginfo-0.9.6-1.fc13.i686.rpm kwebkitpart-0.9.6-1.fc13.x86_64.rpm kwebkitpart-devel-0.9.6-1.fc13.x86_64.rpm kwebkitpart-debuginfo-0.9.6-1.fc13.x86_64.rpm kwebkitpart-0.9.6-1.fc13.src.rpm
kwebkitpart.src: W: no-buildroot-tag
7 packages and 0 specfiles checked; 0 errors, 1 warnings.

Scratch builds:
F13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2349915
F14: http://koji.fedoraproject.org/koji/taskinfo?taskID=2349918

This package obsoletes webkitpart which is subpackage of webkitkde.
webkitkde was obsoleted in kdelibs.

Comment 1 Rex Dieter 2010-09-14 23:25:11 UTC
naming : ok

scriptlets : ok

license : ok

sources:
$ md5sum *.bz2
017b56eae5462617bf5fded092280e1f  127960-kwebkitpart-0.9.6.tar.bz2

rpmlint clean (as noted)

builds in mock

installs/upgrades cleanly, Obsoletes properly.

functions ok in casual usage.


Small nitpicks that can be fixed post review:
1. -devel: 
change 
Requires: kdelibs4-devel >= 4.4.0
to just
Requires: kdelibs4-devel
(the versioning is handled already via the runtime dependencies)

2.  since this is multilib'd should change
%{?_kde4_version:Requires: kdelibs4>= %{_kde4_version}}
to
%{?_kde4_version:Requires: kdelibs4%{?_isa} >= %{_kde4_version}}


APPROVED.

Comment 2 nucleo 2010-09-15 12:01:25 UTC
(In reply to comment #1)
> Small nitpicks that can be fixed post review:
Fixed.

> APPROVED.
Thank you.


New Package SCM Request
=======================
Package Name: kwebkitpart
Short Description: A KPart based on QtWebKit
Owners: nucleo rdieter
Branches: f12 f13 f14
InitialCC:

Comment 3 Jens Petersen 2010-09-16 04:09:56 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2010-09-16 09:19:10 UTC
kwebkitpart-0.9.6-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/kwebkitpart-0.9.6-1.fc14

Comment 5 Fedora Update System 2010-09-16 09:19:44 UTC
kwebkitpart-0.9.6-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/kwebkitpart-0.9.6-1.fc13

Comment 6 Fedora Update System 2010-09-16 09:20:21 UTC
kwebkitpart-0.9.6-1.fc12 has been submitted as an update for Fedora 12.
https://admin.fedoraproject.org/updates/kwebkitpart-0.9.6-1.fc12

Comment 7 Fedora Update System 2010-09-17 04:05:50 UTC
kwebkitpart-0.9.6-1.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update kwebkitpart'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/kwebkitpart-0.9.6-1.fc14

Comment 8 Fedora Update System 2010-09-23 04:55:20 UTC
kwebkitpart-0.9.6-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2010-09-23 12:56:15 UTC
kwebkitpart-0.9.6-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2010-09-26 04:36:07 UTC
kwebkitpart-0.9.6-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.