Bug 619788

Summary: vbetool coredumps when parsing incorrect command line input
Product: [Fedora] Fedora Reporter: Zdenek Kabelac <zkabelac>
Component: vbetoolAssignee: Adam Jackson <ajax>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: ajax, mjg59, pknirsch
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-29 17:52:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Zdenek Kabelac 2010-07-30 14:35:50 UTC 
Description of problem:

I've just noticed the vbetool crashes with coredump on this command line:

'vbetool dpms'

(i.e.  on/off is missing option in this case)
Obviously  there is missing check before accessing (strcmp(argv[2], "on")
that argc is high enough for this.

#0  0x000000000040202e in main (argc=2, argv=0x7fffd70fa1a8) at vbetool.c:113
113			if (!strcmp(argv[2], "on")) {


Version-Release number of selected component (if applicable):
vbetool-1.2.2-1.fc12.x86_64

How reproducible:


Steps to Reproduce:
1. vbetool dpms
2.
3.
  
Actual results:


Expected results:
Error message/error code - just not coredump....

Additional info:
Comment 1 Adam Jackson 2012-08-29 17:52:09 UTC 
vbetool is dead.