Bug 619788 - vbetool coredumps when parsing incorrect command line input
vbetool coredumps when parsing incorrect command line input
Product: Fedora
Classification: Fedora
Component: vbetool (Show other bugs)
All Linux
low Severity medium
: ---
: ---
Assigned To: Adam Jackson
Fedora Extras Quality Assurance
Depends On:
  Show dependency treegraph
Reported: 2010-07-30 10:35 EDT by Zdenek Kabelac
Modified: 2012-08-29 13:52 EDT (History)
3 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2012-08-29 13:52:09 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Zdenek Kabelac 2010-07-30 10:35:50 EDT
Description of problem:

I've just noticed the vbetool crashes with coredump on this command line:

'vbetool dpms'

(i.e.  on/off is missing option in this case)
Obviously  there is missing check before accessing (strcmp(argv[2], "on")
that argc is high enough for this.

#0  0x000000000040202e in main (argc=2, argv=0x7fffd70fa1a8) at vbetool.c:113
113			if (!strcmp(argv[2], "on")) {

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. vbetool dpms
Actual results:

Expected results:
Error message/error code - just not coredump....

Additional info:
Comment 1 Adam Jackson 2012-08-29 13:52:09 EDT
vbetool is dead.

Note You need to log in before you can comment on or make changes to this bug.