Bug 620738
| Summary: | Review Request: snoopy - A preload library to send shell commands to syslog | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Traylen <steve.traylen> |
| Component: | Package Review | Assignee: | Darryl L. Pierce <dpierce> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dpierce, fedora-package-review, notting, tross |
| Target Milestone: | --- | Flags: | dpierce:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | snoopy-1.7.1-2.fc13 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-08-19 01:16:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Steve Traylen
2010-08-03 11:31:15 UTC
Correction: Spec URL: http://cern.ch/straylen/rpms/snoopy/snoopy.spec MUST: rpmlint must be run on every package. The output should be posted in the review.[1] (mcpierce@mcpierce-laptop:temp)$ rpmlint ~/Packaging/rpms/SRPMS/snoopy-1.6.1-1.fc13.src.rpm ~/Packaging/rpms/RPMS/x86_64/snoopy-* snoopy.src: W: spelling-error Summary(en_US) preload -> reload, p reload, prelude snoopy.src: W: spelling-error Summary(en_US) syslog -> dyslogia, systole, slogan snoopy.src: W: spelling-error %description -l en_US execve -> executive, execked, execute snoopy.src: W: spelling-error %description -l en_US syslog -> dyslogia, systole, slogan snoopy.x86_64: W: spelling-error Summary(en_US) preload -> reload, p reload, prelude snoopy.x86_64: W: spelling-error Summary(en_US) syslog -> dyslogia, systole, slogan snoopy.x86_64: W: spelling-error %description -l en_US execve -> executive, execked, execute snoopy.x86_64: W: spelling-error %description -l en_US syslog -> dyslogia, systole, slogan snoopy.x86_64: W: no-soname /usr/lib64/snoopy.so 3 packages and 0 specfiles checked; 0 errors, 9 warnings. MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [10] Not done. And there is no %postun section. Please address this last piece. (In reply to comment #2) > MUST: Every binary RPM package (or subpackage) which stores shared library > files (not just symlinks) in any of the dynamic linker's default paths, must > call ldconfig in %post and %postun. [10] > > Not done. And there is no %postun section. > > Please address this last piece. Yes of course: Spec URL: http://scern.ch/straylen/rpms/snoopy/snoopy.spec SRPM URL: http://cern.ch/straylen/rpms/snoopy/snoopy-1.6.1-2.el5.src.rpm (In reply to comment #3) > (In reply to comment #2) > > MUST: Every binary RPM package (or subpackage) which stores shared library > > files (not just symlinks) in any of the dynamic linker's default paths, must > > call ldconfig in %post and %postun. [10] > > > > Not done. And there is no %postun section. > > > > Please address this last piece. > > Yes of course: > > > Spec URL: http://scern.ch/straylen/rpms/snoopy/snoopy.spec > SRPM URL: http://cern.ch/straylen/rpms/snoopy/snoopy-1.6.1-2.el5.src.rpm Final changes: 1. Please remove the code to add and remove entries to /etc/ld.so.preload. On Fedora installing a package should not change default behavior like this. Instead, provide instructions to the admin for how to preload the library. 2. Both %post and %postun need to call ldconfig. Please see: http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries With those changes, I'll approve this package. (In reply to comment #4) > Final changes: > > 1. Please remove the code to add and remove entries to /etc/ld.so.preload. On > Fedora installing a package should not change default behavior like this. > Instead, provide instructions to the admin for how to preload the library. That's done, have added a README.Fedora instead. > > 2. Both %post and %postun need to call ldconfig. Please see: > > http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries > They did already but do now as well. Spec URL: http://cern.ch/straylen/rpms/snoopy/snoopy.spec SRPM URL: http://cern.ch/straylen/rpms/snoopy/snoopy-1.6.1-3.el5.src.rpm > With those changes, I'll approve this package. I'll take another look at yours. Steve. New Package SCM Request ======================= Package Name: snoopy Short Description: A preload library to send shell commands to syslog Owners: stevetraylen Branches: f13 f14 el4 el5 el6 Hi Darryl, Thanks for the review. Thinking about this package, I think that given this is override via preload to glibc which is of course in /lib64 then I think this preload should also be in /lib64 rather than /usr/lib64. Not a good change to make immediately after review hence this comment in case you have any comment. If the change is solely in where the library is installed, then I'm okay with it. Git done (by process-git-requests). snoopy-1.7.1-2.el4 has been submitted as an update for Fedora EPEL 4. http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.el4 snoopy-1.7.1-2.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.fc13 snoopy-1.7.1-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.el5 snoopy-1.7.1-2.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.fc14 snoopy-1.7.1-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update snoopy'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.fc13 snoopy-1.7.1-2.el4 has been pushed to the Fedora EPEL 4 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update snoopy'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.el4 snoopy-1.7.1-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update snoopy'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.el5 snoopy-1.7.1-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update snoopy'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.fc14 snoopy-1.7.1-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. snoopy-1.7.1-2.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. snoopy-1.7.1-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. snoopy-1.7.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |