Bug 620738 - Review Request: snoopy - A preload library to send shell commands to syslog
Review Request: snoopy - A preload library to send shell commands to syslog
Status: CLOSED ERRATA
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Darryl L. Pierce
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-03 07:31 EDT by Steve Traylen
Modified: 2015-06-21 20:07 EDT (History)
4 users (show)

See Also:
Fixed In Version: snoopy-1.7.1-2.fc13
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2010-08-18 21:16:15 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
dpierce: fedora‑review+
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Steve Traylen 2010-08-03 07:31:15 EDT
Spec URL: http://scern.ch/straylen/rpms/snoopy/snoopy.spec
SRPM URL: http://cern.ch/straylen/rpms/snoopy/snoopy-1.6.1-1.el5.src.rpm
Description: 
Snoopy is designed to aid a sysadmin by providing a log of commands
executed. Snoopy is completely transparent to the user and applications.
It is linked into programs to provide a wrapper around calls to execve().
Logging is done via syslog.
Comment 1 Steve Traylen 2010-08-03 07:33:05 EDT
Correction:

Spec URL: http://cern.ch/straylen/rpms/snoopy/snoopy.spec
Comment 2 Darryl L. Pierce 2010-08-03 15:32:18 EDT
MUST: rpmlint must be run on every package. The output should be posted in the review.[1]

(mcpierce@mcpierce-laptop:temp)$ rpmlint ~/Packaging/rpms/SRPMS/snoopy-1.6.1-1.fc13.src.rpm ~/Packaging/rpms/RPMS/x86_64/snoopy-*
snoopy.src: W: spelling-error Summary(en_US) preload -> reload, p reload, prelude
snoopy.src: W: spelling-error Summary(en_US) syslog -> dyslogia, systole, slogan
snoopy.src: W: spelling-error %description -l en_US execve -> executive, execked, execute
snoopy.src: W: spelling-error %description -l en_US syslog -> dyslogia, systole, slogan
snoopy.x86_64: W: spelling-error Summary(en_US) preload -> reload, p reload, prelude
snoopy.x86_64: W: spelling-error Summary(en_US) syslog -> dyslogia, systole, slogan
snoopy.x86_64: W: spelling-error %description -l en_US execve -> executive, execked, execute
snoopy.x86_64: W: spelling-error %description -l en_US syslog -> dyslogia, systole, slogan
snoopy.x86_64: W: no-soname /usr/lib64/snoopy.so
3 packages and 0 specfiles checked; 0 errors, 9 warnings.

MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [10]

Not done. And there is no %postun section.

Please address this last piece.
Comment 3 Steve Traylen 2010-08-03 15:43:51 EDT
(In reply to comment #2)
> MUST: Every binary RPM package (or subpackage) which stores shared library
> files (not just symlinks) in any of the dynamic linker's default paths, must
> call ldconfig in %post and %postun. [10]
> 
> Not done. And there is no %postun section.
> 
> Please address this last piece.   

Yes of course:


Spec URL: http://scern.ch/straylen/rpms/snoopy/snoopy.spec
SRPM URL: http://cern.ch/straylen/rpms/snoopy/snoopy-1.6.1-2.el5.src.rpm
Comment 4 Darryl L. Pierce 2010-08-04 08:24:48 EDT
(In reply to comment #3)
> (In reply to comment #2)
> > MUST: Every binary RPM package (or subpackage) which stores shared library
> > files (not just symlinks) in any of the dynamic linker's default paths, must
> > call ldconfig in %post and %postun. [10]
> > 
> > Not done. And there is no %postun section.
> > 
> > Please address this last piece.   
> 
> Yes of course:
> 
> 
> Spec URL: http://scern.ch/straylen/rpms/snoopy/snoopy.spec
> SRPM URL: http://cern.ch/straylen/rpms/snoopy/snoopy-1.6.1-2.el5.src.rpm    

Final changes:

1. Please remove the code to add and remove entries to /etc/ld.so.preload. On Fedora installing a package should not change default behavior like this. Instead, provide instructions to the admin for how to preload the library.

2. Both %post and %postun need to call ldconfig. Please see:

http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries

With those changes, I'll approve this package.
Comment 5 Steve Traylen 2010-08-04 09:03:59 EDT
(In reply to comment #4)

> Final changes:
> 
> 1. Please remove the code to add and remove entries to /etc/ld.so.preload. On
> Fedora installing a package should not change default behavior like this.
> Instead, provide instructions to the admin for how to preload the library.

That's done, have added a README.Fedora instead.

> 
> 2. Both %post and %postun need to call ldconfig. Please see:
>
> http://fedoraproject.org/wiki/Packaging/Guidelines#Shared_Libraries
>

They did already but do now as well.


Spec URL: http://cern.ch/straylen/rpms/snoopy/snoopy.spec
SRPM URL: http://cern.ch/straylen/rpms/snoopy/snoopy-1.6.1-3.el5.src.rpm    


> With those changes, I'll approve this package.    

I'll take another look at yours.

Steve.
Comment 6 Steve Traylen 2010-08-04 10:35:22 EDT
New Package SCM Request
=======================
Package Name: snoopy
Short Description: A preload library to send shell commands to syslog
Owners: stevetraylen
Branches: f13 f14 el4 el5 el6
Comment 7 Steve Traylen 2010-08-04 10:47:03 EDT
Hi Darryl,

Thanks for the review.

Thinking about this package, I think that given this is override
via preload to glibc which is of course in /lib64 then I think
this preload should also be in /lib64 rather than /usr/lib64.

Not a good change to make immediately after review hence this comment
in case you have any comment.
Comment 8 Darryl L. Pierce 2010-08-04 11:07:55 EDT
If the change is solely in where the library is installed, then I'm okay with it.
Comment 9 Kevin Fenzi 2010-08-05 13:09:57 EDT
Git done (by process-git-requests).
Comment 10 Fedora Update System 2010-08-05 14:33:14 EDT
snoopy-1.7.1-2.el4 has been submitted as an update for Fedora EPEL 4.
http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.el4
Comment 11 Fedora Update System 2010-08-05 14:33:22 EDT
snoopy-1.7.1-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.fc13
Comment 12 Fedora Update System 2010-08-05 14:33:29 EDT
snoopy-1.7.1-2.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.el5
Comment 13 Fedora Update System 2010-08-05 14:33:34 EDT
snoopy-1.7.1-2.fc14 has been submitted as an update for Fedora 14.
http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.fc14
Comment 14 Fedora Update System 2010-08-05 19:33:13 EDT
snoopy-1.7.1-2.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update snoopy'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.fc13
Comment 15 Fedora Update System 2010-08-06 15:55:31 EDT
snoopy-1.7.1-2.el4 has been pushed to the Fedora EPEL 4 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update snoopy'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.el4
Comment 16 Fedora Update System 2010-08-06 15:57:02 EDT
snoopy-1.7.1-2.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update snoopy'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.el5
Comment 17 Fedora Update System 2010-08-09 21:31:40 EDT
snoopy-1.7.1-2.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update snoopy'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/snoopy-1.7.1-2.fc14
Comment 18 Fedora Update System 2010-08-18 21:16:11 EDT
snoopy-1.7.1-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 19 Fedora Update System 2010-08-23 12:44:05 EDT
snoopy-1.7.1-2.el4 has been pushed to the Fedora EPEL 4 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 20 Fedora Update System 2010-08-23 12:44:28 EDT
snoopy-1.7.1-2.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 21 Fedora Update System 2010-08-23 18:03:48 EDT
snoopy-1.7.1-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.