Bug 622904
| Summary: | Review Request: rubygem-state_machine - Adds support for creating state machines for attributes on any Ruby class | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Guillermo Gómez <guillermo.gomez> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | a.badger, fedora-package-review, mastahnke, notting |
| Target Milestone: | --- | Flags: | mastahnke:
fedora-review+
a.badger: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-09-01 19:44:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Guillermo Gómez
2010-08-10 18:29:47 UTC
rubygem-state_machine is already in Fedora. Is it correct that this review request is for recheck of this, because it is long (actually almost one year) since the last rubygem-state_machine is built on koji? I understand that it has to be treated as a new pkg since the last update its one year old. quote Re-review required for older packages If a package was last updated more than three months ago (running cvs log -r HEAD *.spec can show you this information), you will need to submit a review request and have the package approved by a reviewer as if it were new to Fedora. am i getting it wrong ? http://fedoraproject.org/wiki/Orphaned_package_that_need_new_maintainers Well, just a confirmation, thanks. Macro %sitelib is not used anywhere. It can be removed.
Package builds in mock without issues.
rpmlint lists normal warnings about macros.
I have a small wish that there was a -doc package as 573 files of 737 are documentation, but it doesn't take up that much space.
In some of my packages %{geminstdir}/test is marked as %doc and not in others. I am guessing we need to agree on this one. I'll ask on the list.
This package looks like it is in pretty good shape.
New spec and srpm, -doc pkg produced. http://gomix.fedorapeople.org/rubygem-state_machine/rubygem-state_machine.spec http://gomix.fedorapeople.org/rubygem-state_machine/rubygem-state_machine-0.9.4-2.fc13.src.rpm $ rpmlint -i rubygem-state_machine.spec rubygem-state_machine-0.9.4-2.fc13.src.rpm 1 packages and 1 specfiles checked; 0 errors, 0 warnings. wish granted :) Any news on this review? :) rubygem-state_machine-doc.noarch: W: summary-ended-with-dot C Documentation files, rdoc, ri, examples and tests. Just fix that when you import the package. Package APPROVED. Thank u Michael... :) updates requests done for updates-testing with the fix https://admin.fedoraproject.org/updates/search/rubygem-state_machine What is the status of this bug? Can this bug be closed? Thanks Mamoru, closed ! Its on F12 and F13 stable already. Package Change Request ====================== Package Name: rubygem-state_machine New Branches: el5 el6 Owners: gomix New Package SCM Request ======================= Package Name: rubygem-state_machine Short Description: Adds support for creating state machines for attributes on any Ruby class Owners: gomix Branches: el6 el5 InitialCC: gomix Git done. rubygem-state_machine-0.9.4-6.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/rubygem-state_machine-0.9.4-6.el5 rubygem-state_machine-0.9.4-6.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/rubygem-state_machine-0.9.4-6.el6 rubygem-state_machine-0.9.4-6.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. rubygem-state_machine-0.9.4-6.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |