Bug 623507

Summary: fix coverity Defect Type: Incorrect expression issues
Product: [Retired] 389 Reporter: Noriko Hosoi <nhosoi>
Component: Directory ServerAssignee: Noriko Hosoi <nhosoi>
Status: CLOSED CURRENTRELEASE QA Contact: Chandrasekar Kannan <ckannan>
Severity: medium Docs Contact:
Priority: low    
Version: 1.2.6CC: benl
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-17 14:08:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 576869, 639035    
Attachments:
Description Flags
git patch file (master)
nkinder: review+
git patch file (master) nkinder: review+

Description Noriko Hosoi 2010-08-12 00:19:14 UTC 
Description of problem:
fix coverity Defect Type: Incorrect expression issues
Comment 1 Noriko Hosoi 2010-08-12 00:55:34 UTC 
Created attachment 438320 [details]
git patch file (master)

11957
http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11957&streamDefectId=12143&defectInstanceId=14008&fileInstanceId=49055

Comment:
be_list is never NULL so there is no need to check for NULL value.
Comment 2 Noriko Hosoi 2010-08-12 01:02:57 UTC 
Created attachment 438321 [details]
git patch file (master)

11959
http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11959&streamDefectId=12145&defectInstanceId=14010&fileInstanceId=49686

Comment:
readonly_attributes is never NULL so it's not necessary to compare
with NULL.
Comment 3 Noriko Hosoi 2010-08-20 22:07:07 UTC 
Reviewed by Nathan (Thank you!!)

Pushed to master:

$ git merge coverity
Updating d5b1593..d7c4d9b
Fast-forward
 ldap/servers/slapd/opshared.c |    2 +-
 ldap/servers/slapd/rootdse.c  |    4 ----
 2 files changed, 1 insertions(+), 5 deletions(-)

$ git push
Counting objects: 18, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (12/12), done.
Writing objects: 100% (12/12), 1.18 KiB, done.
Total 12 (delta 9), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
   d5b1593..d7c4d9b  master -> master