Bug 623507 - fix coverity Defect Type: Incorrect expression issues
Summary: fix coverity Defect Type: Incorrect expression issues
Status: CLOSED CURRENTRELEASE
Alias: None
Product: 389
Classification: Retired
Component: Directory Server   
(Show other bugs)
Version: 1.2.6
Hardware: All
OS: Linux
low
medium
Target Milestone: ---
Assignee: Noriko Hosoi
QA Contact: Chandrasekar Kannan
URL:
Whiteboard:
Keywords:
Depends On:
Blocks: 389_1.2.7 639035
TreeView+ depends on / blocked
 
Reported: 2010-08-12 00:19 UTC by Noriko Hosoi
Modified: 2015-01-04 23:43 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2011-05-17 14:08:35 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
git patch file (master) (1.14 KB, patch)
2010-08-12 00:55 UTC, Noriko Hosoi
nkinder: review+
Details | Diff
git patch file (master) (951 bytes, patch)
2010-08-12 01:02 UTC, Noriko Hosoi
nkinder: review+
Details | Diff

Description Noriko Hosoi 2010-08-12 00:19:14 UTC
Description of problem:
fix coverity Defect Type: Incorrect expression issues

Comment 1 Noriko Hosoi 2010-08-12 00:55:34 UTC
Created attachment 438320 [details]
git patch file (master)

11957
http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11957&streamDefectId=12143&defectInstanceId=14008&fileInstanceId=49055

Comment:
be_list is never NULL so there is no need to check for NULL value.

Comment 2 Noriko Hosoi 2010-08-12 01:02:57 UTC
Created attachment 438321 [details]
git patch file (master)

11959
http://10.16.47.145:8080/sourcebrowser.htm?projectId=10030#mergedDefectId=11959&streamDefectId=12145&defectInstanceId=14010&fileInstanceId=49686

Comment:
readonly_attributes is never NULL so it's not necessary to compare
with NULL.

Comment 3 Noriko Hosoi 2010-08-20 22:07:07 UTC
Reviewed by Nathan (Thank you!!)

Pushed to master:

$ git merge coverity
Updating d5b1593..d7c4d9b
Fast-forward
 ldap/servers/slapd/opshared.c |    2 +-
 ldap/servers/slapd/rootdse.c  |    4 ----
 2 files changed, 1 insertions(+), 5 deletions(-)

$ git push
Counting objects: 18, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (12/12), done.
Writing objects: 100% (12/12), 1.18 KiB, done.
Total 12 (delta 9), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
   d5b1593..d7c4d9b  master -> master


Note You need to log in before you can comment on or make changes to this bug.