Bug 623667
| Summary: | seeker hits random bytes unaligened | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ege Turgay <ege.turgay> | ||||
| Component: | seeker | Assignee: | Ville Skyttä <ville.skytta> | ||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 13 | CC: | ville.skytta | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 3.0-3 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-08-19 11:24:01 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
http://pkgs.fedoraproject.org/gitweb/?p=seeker.git;a=commitdiff;h=fe5760ae0e426449aeb7d5357b30a0f9b3749a5d Thanks, modified patch applied in devel and built for Rawhide, let's see if someone spots a problem with it. |
Created attachment 438437 [details] the patched code Description of problem: i've been told that it wasn't testing the i/o accurately because it was choosing its starting location as a random number of bytes into the disk, then the most of the time you will need to read two sectors to get 512 bytes. only if you choose a starting byte divisible by 512 will you read your whole 512 bytes from a single sector. Using direct i/o with memory and buffer alignment fixes this issue as well. One of my colleagues (Mr. Ian Sherratt) patched this, so i don't have a good understanding of the code. I've attached the patched version Version-Release number of selected component (if applicable): How reproducible: always Steps to Reproduce: 1. just running the test 2. 3. Actual results: n/a Expected results: n/a Additional info: