Bug 623788

(In reply to comment #0)

> The init script is broken for restarts.  I think this fixes:

It appears that this should read:

   status -p /var/run/autofs.pid -l $prog

instead of 

   status -p /var/run/autofs.pid -l autofs $prog

but this indeed fixes the problem for me.  autofs-5.0.5-26.fc13 has surely broken startup script as 'status > /dev/null 2>&1' invariably ends as 1.

I think my original is correct. -p is pid file, -l is lock file name, and then you pass the program name.

(In reply to comment #2)
> I think my original is correct. -p is pid file, -l is lock file name, and then
> you pass the program name.    

Yes, I think that you are right. OTOH it appears that just
'status -p /var/run/autofs.pid' is good enough and remaining arguments are not that essential.

(In reply to comment #3)
> (In reply to comment #2)
> > I think my original is correct. -p is pid file, -l is lock file name, and then
> > you pass the program name.    
> 
> Yes, I think that you are right. OTOH it appears that just
> 'status -p /var/run/autofs.pid' is good enough and remaining arguments are not
> that essential.

It turns out that changing the status call to "status autofs"
will use the correct pid file.

*** Bug 624694 has been marked as a duplicate of this bug. ***

autofs-5.0.5-27.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/autofs-5.0.5-27.fc13

(In reply to comment #6)
> autofs-5.0.5-27.fc13 has been submitted as an update for Fedora 13.
> http://admin.fedoraproject.org/updates/autofs-5.0.5-27.fc13

Can you all try this build please.

(In reply to comment #7)
> 
> Can you all try this build please.

Yes, it does work in my tests.  OTOH I noticed only now that while running
'service autofs status' you are going full blast:

case "$1" in
...
        status)
                status -p /var/run/autofs.pid -l autofs $prog
                ;;
...

Does it matter that two ways in two places are used or this is by design?

(In reply to comment #8)
> (In reply to comment #7)
> > 
> > Can you all try this build please.
> 
> Yes, it does work in my tests.  OTOH I noticed only now that while running
> 'service autofs status' you are going full blast:
> 
> case "$1" in
> ...
>         status)
>                 status -p /var/run/autofs.pid -l autofs $prog
>                 ;;
> ...
> 
> Does it matter that two ways in two places are used or this is by design?

From a sensibility point of view it probably does matter.

It turns out that "status autofs" is equivalent to
"status -p /var/run/autofs.pid" as long as the pid file is
located in /var/run.

So it would only be a problem if the location of the pid
file changed which isn't likely. At some point I'll need
to go over the entire init script and fix these little
inconsistencies, but for now I'd rather leave it as it is.

(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > 
> > > Can you all try this build please.
> > 
> > Yes, it does work in my tests.  OTOH I noticed only now that while running
> > 'service autofs status' you are going full blast:
> > 
> > case "$1" in
> > ...
> >         status)
> >                 status -p /var/run/autofs.pid -l autofs $prog
> >                 ;;
> > ...
> > 
> > Does it matter that two ways in two places are used or this is by design?
> 
> From a sensibility point of view it probably does matter.
> 
> It turns out that "status autofs" is equivalent to
> "status -p /var/run/autofs.pid" as long as the pid file is
> located in /var/run.

Similarly the "autofs" parameter also covers the -l.

The reason that the -p and the -l was needed in the first
place was that $prog is not the same as the base name of
the pid and lock files, which is autofs rather than
automount.

autofs-5.0.5-27.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update autofs'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/autofs-5.0.5-27.fc13

autofs-5.0.5-28.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/autofs-5.0.5-28.fc13

autofs-5.0.5-28.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.