Bug 624316

This machine may be "in the field" between a beginning of September and the end of December so please take that into account if any further information is required.

Instead of an outright commenting out 'remove_all_video_quirks', which I did while trying figure that out, the following version of 'have_kms' works without doing, hopefully, too much damage elsewhere:

have_kms()
{
    # if we are running with a KMS-enabled video driver, we should not
    # attempt to run any quirks (unless this is intel video)
    if [ -d /sys/module/i915 ] ; then
        have_smart_intel
    else
        grep -q -E '(nouveau|drm)fb' /proc/fb || return 1
        remove_all_video_quirks
    fi
    add_parameters --quirk-no-chvt
}

Created attachment 439033 [details]
possible patch for 98smart-kernel-video

Does it work with KMS?

(In reply to comment #4)
> Does it work with KMS?

I am not sure if I understand the question.  As I wrote in the original report
"There is no choice of running with nomodeset ..." because X server without KMS and with an intel driver simply does not start.  OTOH with KMS and with unpatched 98smart-kernel-video after a resume from a suspend my laptop is dead.

If I would be running without KMS then the patch from comment 3 should have no effects.  No?

Thanks for info. AFAIK KMS should correctly work without quirks, that's why the quirks are removed. I checked with my Intel graphics and everything is working OK without quirks. Thus this seems to be a bug related to your HW that should be fixed in kernel driver. Quirks from user space is not correct way how to handle it and also it can break things for other users -> I will reassign this to kernel.

(In reply to comment #6)
> Thanks for info. AFAIK KMS should correctly work without quirks, that's why the
> quirks are removed.

Only it does not and quirks removal is killing video.

> I checked with my Intel graphics and everything is working
> OK without quirks.

That depends on a particular machine and its BIOS.  Quite a few of those with intel video worked just fine without any quirks _before_ KMS showed up and other models required quirks.

> Thus this seems to be a bug related to your HW that should
> be fixed in kernel driver. Quirks from user space is not correct way how to
> handle it and also it can break things for other users -> I will reassign this
> to kernel.

See bug 546994 which is still in a NEW state and bug 573215 (also NEW so far).
As for "breaking things for other users" if quirks were not needed before then none will be applied even with a proposed patch. So far you are breaking things for "other users" with a help of a long standing regression.

I tried suspend and hibernate with my modification to 98smart-kernel-video on another laptop with an intel video.  Only in this case everything which showed up as "Adding quirks from HAL:" in /var/log/pm-suspend.log was removed by have_smart_intel() function so in this case this is effectively a null change (and suspend and hibernate do work correctly before and after).

BTW - in remove_all_video_quirks() and have_smart_intel() from 98smart-kernel-video there are pairs of lines:

        --quirk-vbe-post \
        --quirk-vbe-post \

That looks a bit excessive if harmless. '--quirk-radeon-off' in have_smart_intel() is to cover a case of multiple video cards?

Reassigning this to the intel driver as mentioned in comment 6

A note before anybody will ask.  That particular laptop with the video issue is now "working out there" and I will not see it before the second half of December.  Another netbook with i915 video is fine as noted in comment 8.  Not that surprising as it never required --quirk-s3-bios and/or --quirk-s3-mode.

This message is a reminder that Fedora 13 is nearing its end of life.
Approximately 30 (thirty) days from now Fedora will stop maintaining
and issuing updates for Fedora 13.  It is Fedora's policy to close all
bug reports from releases that are no longer maintained.  At that time
this bug will be closed as WONTFIX if it remains open with a Fedora 
'version' of '13'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version prior to Fedora 13's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we may not be able to fix it before Fedora 13 is end of life.  If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora please change the 'version' of this 
bug to the applicable version.  If you are unable to change the version, 
please add a comment here and someone will do it for you.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Fedora 13 changed to end-of-life (EOL) status on 2011-06-25. Fedora 13 is 
no longer maintained, which means that it will not receive any further 
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of 
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.