Bug 624419
| Summary: | fedpkg chain-build foo : doesn't put current package into it's own build group | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rex Dieter <rdieter> |
| Component: | fedora-packager | Assignee: | David Cantrell <dcantrell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 13 | CC: | dcantrell, dennis, loganjerry |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | fedora-packager-0.5.1.4-1.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-08-24 21:06:12 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Rex Dieter
2010-08-16 12:01:23 UTC
Here's a patch that fixes the issue.
--- fedpkg.orig 2010-08-13 08:18:55.000000000 -0600
+++ fedpkg 2010-08-17 08:48:14.387138421 -0600
@@ -367,10 +367,9 @@
log.error('Could not get a build url for %s: %s'
% (component, e))
sys.exit(1)
- # Take care of the last build set if we have one
- if build_set:
- log.debug('Created a build set: %s' % ' '.join(build_set))
- urls.append(build_set)
+ # Take care of the last build set
+ log.debug('Created a build set: %s' % ' '.join(build_set))
+ urls.append(build_set)
# pass it off to build
args.chain = urls
args.skip_tag = False
If build_set is nonempty, then we clearly want to append it to urls.
If build_set is empty, due to a trailing ':', then we still want to append it to urls, because the current module is appended to the last element of urls. By appending the empty build_set, we ensure that the current module will be the only element of that last element; i.e., it is in a group by itself.
I fixed this, along with a lot of other issues in chain building with http://git.fedorahosted.org/git/?p=fedora-packager.git;a=commit;h=c6c745e8573b8b8df3b9cf673532263608969de1 fedora-packager-0.5.1.3-1.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/fedora-packager-0.5.1.3-1.fc14 fedora-packager-0.5.1.3-1.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/fedora-packager-0.5.1.3-1.fc13 fedora-packager-0.5.1.3-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/fedora-packager-0.5.1.3-1.fc12 fedora-packager-0.5.1.3-1.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/fedora-packager-0.5.1.3-1.el5 fedora-packager-0.5.1.3-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. fedora-packager-0.5.1.4-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. fedora-packager-0.5.1.4-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. fedora-packager-0.5.1.4-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |