Bug 626726
| Summary: | Review Request: libmsip - A C++ library implementing the SIP protocol | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> |
| Component: | Package Review | Assignee: | Kalev Lember <kalevlember> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, kalevlember, notting |
| Target Milestone: | --- | Flags: | kalevlember:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libmsip-0.8.0-0.1.20100629svn3775.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-08 22:41:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 626446, 626458, 626699 | ||
| Bug Blocks: | |||
|
Description
Peter Lemenkov
2010-08-24 08:30:42 UTC
Correct src.rpm link: http://peter.fedorapeople.org/libmsip-0.8.0-0.1.20100629svn3775.fc12.src.rpm Taking for review. Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2532880 Fedora review libmsip-0.8.0-0.1.20100629svn3775.fc12.src.rpm 2010-10-13
+ OK
! needs attention
rpmlint output:
$ rpmlint libmsip \
libmsip-devel \
libmsip-0.8.0-0.1.20100629svn3775.fc15.src.rpm \
libmsip-debuginfo-0.8.0-0.1.20100629svn3775.fc15.i686.rpm
+ Rpmlint warnings are harmless and can be ignored.
+ The package is named according to the Package Naming Guidelines.
+ Spec file name matches the base package name
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines.
+ The license field in the spec file matches the actual license
+ The package contains license file (COPYING.LIB)
+ Spec file is written in American English
+ Spec file is legible
+ Following instructions in the spec file to check out sources
from upstream svn repo produce matching tarball.
c16fd22c7ec37e9bd2651d9eb59732e1 libmsip-0.8.0.tar.bz2
+ The package builds in koji
n/a ExcludeArch bugs filed
+ BuildRequires look sane
n/a The spec file MUST handle locales properly
+ ldconfig is properly called in %post and %postun
+ Package does not bundle copies of system libraries
n/a Package isn't relocatable
+ Package owns all directories it creates
+ No duplicate files in %files
+ Permissions are properly set and %files has %defattr
+ Consistent use of macros
+ The package must contain code, or permissable content.
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc don't affect the package
+ Header files are in -devel
n/a Static libraries should be in -static
+ Library files that end in .so are in -devel package
+ -devel requires the fully versioned base
+ Package doesn't contain any libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Directory ownership sane
+ Filenames are valid UTF-8
Looks good.
APPROVED
New Package SCM Request ======================= Package Name: libmsip Short Description: A C++ library implementing the SIP protocol Owners: peter Branches: f12 f13 f14 el6 InitialCC: Git done (by process-git-requests). libmsip-0.8.0-0.1.20100629svn3775.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/libmsip-0.8.0-0.1.20100629svn3775.fc13 libmsip-0.8.0-0.1.20100629svn3775.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/libmsip-0.8.0-0.1.20100629svn3775.fc12 libmsip-0.8.0-0.1.20100629svn3775.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/libmsip-0.8.0-0.1.20100629svn3775.fc14 libmsip-0.8.0-0.1.20100629svn3775.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update libmsip'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/libmsip-0.8.0-0.1.20100629svn3775.fc12 libmsip-0.8.0-0.1.20100629svn3775.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. libmsip-0.8.0-0.1.20100629svn3775.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. libmsip-0.8.0-0.1.20100629svn3775.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |