Bug 626975

Summary:	Blinking keyb leds in spice client causes capslock to turn on / off all the time in other windows
Product:	Red Hat Enterprise Linux 6	Reporter:	Hans de Goede <hdegoede>
Component:	spice-client	Assignee:	Hans de Goede <hdegoede>
Status:	CLOSED ERRATA	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	medium	Docs Contact:
Priority:	low
Version:	6.0	CC:	alevy, jrb, lkocman, marcandre.lureau, mhasko, mkenneth, uril
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	spice-client-0.7.2-1.el6	Doc Type:	Bug Fix
Doc Text:	For content author, I think users did not see this bug, but it was discovered during development. The Problem: Upon (linux) guest panic, a spice-client connected to the VM caused client's keyboard leds to blink and capslock to turn on/off continuously, in non-spice-client windows too. The Fix: Blocking keyboard modifier events when spice-client windows is not in-focus. That means when the user focuses out of spice-client window (focus on a different window), blinks stop blinking and caps-lock does not turn on/off.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-05-19 13:14:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	671383

Description Hans de Goede 2010-08-24 19:10:14 UTC

Steps to Reproduce:
1. Run linux kernel in guest make it panic (no initrd cannot find root for example)
2. Connect spice client to the vm with the blinking keyb leds from the kernel panic
3. Switch to another window and try to type something, notice how every few ohter letters the letters change from caps to lowercase or vica versa.

Comment 2 Marc-Andre Lureau 2010-11-02 00:30:04 UTC

I have a trivial workaround for that bug, just blocking modifier events when focus_out(). It could be done differently.

http://gitorious.org/~elmarco/spice/elmarco-spice/commit/ae776586b96400070214d85ad073db49bb6925ef

I'll post it on the mailing list for review.

Additionally, should we restore keyboard modifiers when going out of focus? I think we should, given that Spice currently offers a full remote desktop client which feels like a separate machine. However, if the remote windows would be managed by the client, and the root window hidden, then this behavior would be bad.

Comment 4 Alon Levy 2011-01-17 16:43:02 UTC

Marc's patch is now in upstream, commit:

 84c0156 client inputs: stop blinking keyboard when out of focus

Comment 5 Hans de Goede 2011-01-25 13:52:19 UTC

A new spice-client-0.7.2-1.el6 fixing this has been build, moving to modified.

Comment 7 Lubos Kocman 2011-03-09 13:00:46 UTC

Verified on spice-client-0.8.0-1.el6.x86_64.

Comment 8 Uri Lublin 2011-05-09 06:30:02 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
For content author, I think users did not see this bug, but it was discovered during development.

The Problem:
Upon (linux) guest panic, a spice-client connected to the VM caused client's keyboard leds to blink and capslock to turn on/off continuously, in non-spice-client windows too.

The Fix:
Blocking keyboard modifier events when
spice-client windows is not in-focus.
That means when the user focuses out of spice-client window (focus on a different window), blinks stop blinking and caps-lock does not turn on/off.

Comment 9 errata-xmlrpc 2011-05-19 13:14:51 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0583.html