Bug 628631
Summary: | Review Request: rubygem-httparty - Makes HTTP fun! Also, makes consuming restful web services dead easy | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michael Stahnke <mastahnke> |
Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting |
Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-09-11 16:11:14 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Michael Stahnke
2010-08-30 14:59:44 UTC
Well, I will take this one and bug 630054. Instead I will appreciate it if you would review my review requests bug 630480 and bug 630481. Note that I am going to take a rest now... Some notes: ! BR(check) - From ./spec/spec_helper.rb : -------------------------------------------------------- 1 require File.join(File.dirname(__FILE__), '..', 'lib', 'httparty') 2 require 'spec/autorun' 3 require 'fakeweb' -------------------------------------------------------- For BR(check): rubygem(fakeweb) seems also needed. I hope someone will package this. * Requires - Usually ">= 0.1.8" on "R: rubygem(crack)" is not needed (is usually removed) because rubygem-crack on currently supported Fedora branches all satisfy this dependency, ref: https://fedoraproject.org/wiki/Packaging/Guidelines#Explicit_Requires However, looking at gemspecfile, httparty-0.6.1.gemspec contains: -------------------------------------------------------- 29 if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then 30 s.add_runtime_dependency(%q<crack>, ["= 0.1.8"]) -------------------------------------------------------- So for this case, I suggest - to make the dependency for rubygem(crack) strict (i.e. use "R: rubygem(crack) = 0.1.8" - or remove strict version dependency for rubygem-crack on gemspec file By the way, would you import rubygem-crack also for F-14/13? I haven't put crack in F-14/F13 yet because shoulda isn't there yet. I am working with the maintainer on that. Changed to a strict dependency for rubygem-crack. = 0.1.8 New version http://stahnma.fedorapeople.org/reviews/rubygem-httparty-0.6.1-2.fc15.src.rpm Approving ------------------------------------------------------------------ This package (rubygem-httparty) is APPROVED by mtasaka ------------------------------------------------------------------ New Package SCM Request ======================= Package Name: rubygem-httparty Short Description: Makes HTTP fun! Also, makes consuming restful web services dead easy Owners: stahnma Branches: F13 F14 EL5 EL6 InitialCC: Git done (by process-git-requests). Closing. |