Spec URL: http://stahnma.fedorapeople.org/reviews/rubygem-facon.spec SRPM URL: http://stahnma.fedorapeople.org/reviews/rubygem-facon-0.4.1-1.fc15.src.rpm Description: Tiny mocking library
Some notes: * Dependency - rubygem(hoe) is for development dependency (especially needed for "rake spec"), however is not needed for runtime (i.e. "R: rubygem(hoe)" is not needed) ? %check -------------------------------------------------------------- # Requires internet connection to rubyforge # unable to run tests on build infrastructure -------------------------------------------------------------- - Well, what error are you seeing without net connection? At least on F-14 "rake spec" works on koji (with proper BR installed, currently fails with "43 examples, 1 failure"). Maybe you are seeing some working from hoe like: -------------------------------------------------------------- Couldn't read /builddir/.rubyforge/user-config.yml. Run `rubyforge setup`. -------------------------------------------------------------- however this can be ignored. From rubygem-hoe History.txt: -------------------------------------------------------------- === 2.6.1 / 2010-06-02 * Fix up hoe to be happy when rubyforge is missing or misconfigured --------------------------------------------------------------
You're right about the hoe/rubyforge issue. Now I am trying to figure out the one failure. It fails on Fedora, Mac OS, and RHEL. If you have a newer ruby version, it doesn't seem to fail. 1.8.7 p302 seems to work without issues (according to a friend's install). I don't understand exactly what is failing. Should I just make tests exit gracefully or keep working on the one failing? I will also fix the R vs BR for hoe.
Well, I run F-14 (which is using ruby 1.8.7 p302) and $ rake spec fails with one test: 1) NoMethodError in 'A mock object should raise a MockExpectationError if block for expectation fails' undefined method `message' for false:FalseClass ./spec/expectation_spec.rb:105: If you can figure out the cause of test failure it is preferable, however for now I think we can patch out the failing test.
Patched out failing test. http://stahnma.fedorapeople.org/reviews/rubygem-facon-0.4.1-2.fc15.src.rpm
About Patch0: --------------------------------------------------------- patch -p1 ./%{gemdir}/gems/facon-%{version}/spec/expectation_spec.rb < %{PATCH0} --------------------------------------------------------- - Please use defined %geminstdir macro also here. - It is preferable to use %patch0 macro like: ---------------------------------------------------------- pushd .%{geminstdir}/spec/ %patch0 -p0 ---------------------------------------------------------- ! Note that on Fedora %patchX macro adds some additional argument "-s --fuzz=0", especially %patchX checks if the patch can be applied with no fuzz. ------------------------------------------------------------- This package (rubygem-facon) is APPROVED by mtasaka -------------------------------------------------------------
Patch fixed upon import.
New Package SCM Request ======================= Package Name: rubygem-facon Short Description: Tiny mocking library Owners: stahnma Branches: F13 F14 EL5 EL6 InitialCC:
Git done (by process-git-requests).
rubygem-facon-0.4.1-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/rubygem-facon-0.4.1-2.fc13
rubygem-facon-0.4.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/rubygem-facon-0.4.1-2.fc14
rubygem-facon-0.4.1-2.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update rubygem-facon'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-facon-0.4.1-2.fc13
Closing.
rubygem-facon-0.4.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-facon-0.4.1-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.